New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Item Feature #26
Conversation
Visit the preview URL for this PR (updated for commit 9c1ee0d): https://tcl-56-smart-shopping-li-ffe7d--pr26-ym-dn-delete-item-hmi6jql9.web.app (expires Thu, 18 May 2023 19:49:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 9c51cec5927ae3f1253a2134be95c1a07393f9a7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is clear and the functionality is good on my end!
|
||
const checkItem = (e) => { | ||
updateItem(listId, item); | ||
}; | ||
async function handleDelete() { | ||
if (window.confirm('Are you sure you want to delete this item?')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that you made this decision for accessibility issues versus using an alert box. I'll be keeping this in mind for the future!
Co-authored by @yiremorlans
Description
Related Issue
Close #11
Acceptance Criteria
ListItem
component renders a button that allows the user to delete an item from their list when clickeddeleteItem
function inapi/firebase.js
has been filled out, and deletes the item from the Firestore databaseType of Changes
Updates
Before
After
Testing Steps / QA Criteria