Revert "Prevent app from rendering before data has been fetched." #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongranados
changed the title
|
Visit the preview URL for this PR (updated for commit 677c4fd): https://tcl-57-smart-shopping-list--pr54-revert-48-jg-wait-to-nfcbgnme.web.app (expires Fri, 02 Jun 2023 17:33:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: ad3eb6c34c2ec5986fcc218178df5985eb9c9ffb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fetch-before-render incorporated by this PR breaks the application for new users who don't previously have a stored token in
localStorage. Tabling this optimization for now.Related Issue
Acceptance Criteria
Type of Changes
Updates
Before
After
Testing Steps / QA Criteria