Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus add item #35

Open
wants to merge 58 commits into
base: main
Choose a base branch
from
Open

Focus add item #35

wants to merge 58 commits into from

Conversation

CorinaMurg
Copy link
Collaborator

@CorinaMurg CorinaMurg commented Oct 8, 2023 •
edited by shangguanwang

Description

The goal was to bring focus back to the input field after every submission.

Acceptance Criteria

  • Pressing the Enter key or the Add Item button on the AddItem page should always bring the focus back to the input field.

Type of Changes

Type
✓ 🐛 Bug fix
✨ New feature
🔨 Refactoring
💯 Add tests
🔗 Update dependencies
📜 Docs

Testing Steps / QA Criteria

To pull the branch locally, run git pull origin focus-add-item
Next, run git checkout focus-add-item
Install dependencies npm install
Launch the app with npm start

  • Enter several items, one at a time.
  • Alternate between pressing the Enter key or the Add Item button.
  • The focus should always be back to the input field.

shangguanwang and others added 30 commits September 27, 2023 14:54
@shangguanwang
Install Tailwind CSS and Daisy UI for Issue #13
76ed028
@rdpfeifle
Fix tailwind install bug
b352ab6
@rdpfeifle
Add some styling
6ffc33b
@shangguanwang
Add Navbar Styling for Issue #13
a126bb6
@rdpfeifle
Delete unused code and make the hover text color darker
d9be777
@rdpfeifle
Change urgency tag width and position it on the right side with the d…
5b579e8 
…elete icon
@rdpfeifle
Add hide/show feature for item details (urgency tag)
9d6b9bf
@rdpfeifle
Add more margin bottom space and delete unused code
54939e7
@shangguanwang
Add copyToken to clipboard feature for Issue #13
8c68d1f
@shangguanwang
Fix createNewList bug for Issue #12
44d4ac7
@shangguanwang
refactor realData to fix bug for Issue #12
f5e62f3
@shangguanwang
Add text styling to AddItem view and center everything for Issue #13
2de3805
@shangguanwang
Align everything to the center for Home page for Issue #13
819d0b6
@shangguanwang
Align everything to the center for the List page and replace plain CS…
8b78dfc 
…S with Daisy UI btn styling for Issue #13
@shangguanwang
resolve merge conflict due to the bugFix
90fadc7
@shangguanwang
conclude merge
34ca6e3
@shangguanwang
Resolve merge conflict on List.jsx
b4f2fc6
@shangguanwang
Add divider line to Home
5de810e
@shangguanwang
hide Navbar when there is no list token
98ec260
@shangguanwang
small fix on input box styling
d52badf
@rdpfeifle
Modify showDetails button based on data length
f23b449
@rdpfeifle
Add hover styles to copy token button
80bfc83
@rdpfeifle
Modify detail button when length is >= than 1
e618946
@rdpfeifle
Add Daisy UI checkbox style to input element
e0cdfb1
@shangguanwang
Add Font, active NavLink and style modal for Issue #13
34240d1
@shangguanwang
Add hover effect to urgency tag and item card
a0cfa69
@shangguanwang
Add background image and logo for Issue #13
d4d7032
@shangguanwang
Fix main height and scrollbar in Layout and replaced background for I…
c6f5f09 
…ssue #13
@shangguanwang
fix Home height and padding top
2657de5
@rdpfeifle
Change button text to white
a551efa
shangguanwang and others added 21 commits October 4, 2023 09:34
@shangguanwang
move logo image to src/assets folder
a64c26e
@shangguanwang
add line-through for checked list items
430a183
@shangguanwang
Adjust layout height for mobile screen
4f64be1
@rdpfeifle
Remove activeClassName from NavLink components
f7681b0
@rdpfeifle
Add two favicon options and change app title
9a988d3
@shangguanwang
Move Toastify message to center on mobile, move legend down, capitali…
0f16f1f 
…ze item name
@shangguanwang
Modify main height for large screen to 65vh
5aa267c
@shangguanwang
Add whitespace to left and right margin in main
42b1221
@shangguanwang
Adjust default height for main
075a9b9
@shangguanwang
separate div of main with navbar and add a mt to navbar
7b9c493
@shangguanwang
Add About page for Issue #13
a01fdd9
@shangguanwang
Adjust NavLink text size for responsive design
a214cf5
@rdpfeifle
Center first/last sections, add spacing, adjust bubble arrow position
6b8a707
@rdpfeifle
Add NavLink using ArrowLeftIcon with token based navigation
78c29a4
@shangguanwang
Test Responsive Design for the About page
bc3bd15
@rdpfeifle
Update homepage mockup
2e99208
@rdpfeifle
Improve mobile responsiveness of About page
6067bb5
@CorinaMurg
add NFD as parameter to normalizeItemName function in AddItem
6ca596a
@CorinaMurg
Revert "add NFD as parameter to normalizeItemName function in AddItem"
4b6f8ad 
This reverts commit 6ca596a.
@CorinaMurg
Fix a couple of typos
42a1fb4
@CorinaMurg
Add a useRef in AddItem to bring focus to input after every submission
131787c
@github-actions
Copy link

github-actions bot commented Oct 8, 2023

Visit the preview URL for this PR (updated for commit 131787c):

https://tcl-63-smart-shopping-list--pr35-focus-add-item-i7wvtxv7.web.app

(expires Sun, 15 Oct 2023 03:41:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 33cd697c9ae2cd133e732431f4d096ea24d56582

shangguanwang
shangguanwang approved these changes Oct 8, 2023
View reviewed changes
Copy link
Collaborator

@shangguanwang shangguanwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job spotting the focus!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shangguanwang shangguanwang shangguanwang approved these changes

@rdpfeifle rdpfeifle rdpfeifle approved these changes

@AslanTaheri AslanTaheri AslanTaheri approved these changes

@mentalcaries mentalcaries Awaiting requested review from mentalcaries

Assignees

@CorinaMurg CorinaMurg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CorinaMurg @shangguanwang @rdpfeifle @AslanTaheri