Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faq focus #36

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Faq focus #36

wants to merge 9 commits into from

Conversation

CorinaMurg
Copy link
Collaborator

@CorinaMurg CorinaMurg commented Oct 8, 2023

Description

Refactored accordion code to make the component accessible.

Related Issue

None

Acceptance Criteria

  • Accordion elements are tab-able
  • Each accordion element and its status (collapsed/uncollapsed) is announced by screen reader as a button.
  • Only one answer is revealed at a time.

Type of Changes

Type
βœ“ πŸ› Bug fix
✨ New feature
βœ“ πŸ”¨ Refactoring
πŸ’― Add tests
πŸ”— Update dependencies
πŸ“œ Docs

Testing Steps / QA Criteria

To pull our branch locally, run git pull origin faq-focus
Next, run git checkout faq-focus
Install dependencies npm install
Launch the app with npm start

Check for the following:

  1. Each accordion element is tab-able
  2. Each accordion element is announced by screen reader as a button.
  3. The screen reader announces the question and the answer (if open)
  4. Only one answer is revealed at a time.
  5. A dark outline is visible when an element is in focus.

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

Visit the preview URL for this PR (updated for commit a125b00):

https://tcl-63-smart-shopping-list--pr36-faq-focus-biq90ed7.web.app

(expires Sun, 15 Oct 2023 16:07:16 GMT)

πŸ”₯ via Firebase Hosting GitHub Action 🌎

Sign: 33cd697c9ae2cd133e732431f4d096ea24d56582

Copy link
Collaborator

@shangguanwang shangguanwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how you separate the accordion data and accordion as its own separate components! Tested on my end and the screen reader is working, well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants