-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faq focus #36
base: main
Are you sure you want to change the base?
Faq focus #36
Conversation
Visit the preview URL for this PR (updated for commit a125b00): https://tcl-63-smart-shopping-list--pr36-faq-focus-biq90ed7.web.app (expires Sun, 15 Oct 2023 16:07:16 GMT) π₯ via Firebase Hosting GitHub Action π Sign: 33cd697c9ae2cd133e732431f4d096ea24d56582 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love how you separate the accordion data and accordion as its own separate components! Tested on my end and the screen reader is working, well done!
Description
Refactored accordion code to make the component accessible.
Related Issue
None
Acceptance Criteria
Type of Changes
Testing Steps / QA Criteria
To pull our branch locally, run git pull origin faq-focus
Next, run git checkout faq-focus
Install dependencies npm install
Launch the app with npm start
Check for the following: