Change Button Color Contrast to Meet Accessibility Requirement #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 18d6cbf): https://tcl-63-smart-shopping-list--pr37-btn-color-contrast-9w9f97ef.web.app (expires Sun, 15 Oct 2023 21:04:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 33cd697c9ae2cd133e732431f4d096ea24d56582 |
AslanTaheri
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All buttons currently have a light blue background which doesn't pass Lighthouse's accessibility requirement.
Related Issue
Accessibility
Acceptance Criteria
Type of Changes
Updates
Before
After
Testing Steps / QA Criteria
To pull our branch locally, run
git pull origin btn-color-contrastNext, run
git checkout btn-color-contrastLaunch the app with
npm startInstall
LighthouseChrome extension if you don't have it alreadyGo to the
Add Itempage, or any page with the button. Open the console on the browser, go toLighthousetab and Generate a Lighthouse report on the "Accessibility" category, expect to see a rating of 100.