Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve home view #65

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Improve home view #65

merged 5 commits into from
Mar 22, 2024

Conversation

jtkabenni
Copy link
Collaborator

@jtkabenni jtkabenni commented Mar 22, 2024

For an example of how to fill this template out, see this Pull Request.

Description

  • - Make it clear that use can select existing list OR create new list
  • - Remove User ID from list names
  • - Dropdown for finding a list to select
  • - List name displays somewhere on screen after selected
  • - Remove: Hello from the home (/) page!
  • - Remove: Signed in as user_name (Sign Out)
  • - Update to Welcome, user_name
  • - Add header to form, or some kind of description to make it more clear that this is to create a new list.
  • - Update button copy to be more descriptive
  • - Fix for this bug: https://github.com/orgs/the-collab-lab/projects/200/views/1?pane=issue&itemId=56874949

Related Issue

#51
#50

Acceptance Criteria

Type of Changes

Feature update and bug fix

Updates

Before

Screenshot 2024-03-21 at 6 52 55 PM

After

Screenshot 2024-03-21 at 6 52 18 PM

Testing Steps / QA Criteria

Creating a new list

  1. Create a new list, select create list.
  2. Should redirect to list page in 1 second

Selecting a list

  1. Select an existing list from the dropdown
  2. Select list name in h2 should change to the selected list
  3. Clicking 'view list' should bring you to list page
  4. After going back home, list should still be selected

@bdanzer
Copy link
Collaborator

bdanzer commented Mar 22, 2024

In terms of some style enhancements I would also suggest making the buttons, select and inputs have some more padding. Also some spacing away from those elements would be nice too.

@jtkabenni
Copy link
Collaborator Author

In terms of some style enhancements I would also suggest making the buttons, select and inputs have some more padding. Also some spacing away from those elements would be nice too.

Thanks @bdanzer , we were going to do most of the styling in the following week but can probably get started now.

Copy link

Visit the preview URL for this PR (updated for commit ffb29f8):

https://tcl-67-smart-shopping-list--pr65-feature-ab-jt-improv-cafcgpqr.web.app

(expires Fri, 29 Mar 2024 04:08:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1dc6f6876568bd8a1c97781eec7984835c207f7c

@bdanzer
Copy link
Collaborator

bdanzer commented Mar 22, 2024

In terms of some style enhancements I would also suggest making the buttons, select and inputs have some more padding. Also some spacing away from those elements would be nice too.

Thanks @bdanzer , we were going to do most of the styling in the following week but can probably get started now.

No worries on addressing it now, figured I'd mention it. Went ahead and approved!

@jtkabenni jtkabenni merged commit 7a534d6 into main Mar 22, 2024
3 checks passed
@adidalal adidalal deleted the feature/ab-jt-improve-list-selection branch April 8, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants