Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submit save button in add inserting multiple rows in case double click [BUG] #3896

Closed
mohamedaitbella opened this issue Jan 18, 2019 · 6 comments

Comments

@mohamedaitbella
Copy link

mohamedaitbella commented Jan 18, 2019

Version information

  • Laravel: v 5.7.19
  • Voyager: v1.1.11
  • PHP: 7.2.11
  • Database: mysql Ver 14.14

Description

when i'm trying to add record if double click save button
the record is inserted according to number of clicks

Steps To Reproduce

Steps to reproduce the behavior:

  1. in any record
  2. click add new [record product for example]
  3. insert inpute fields
  4. multiple click on the save button

Expected behavior

normally it should only add one record no matter the number of clicks on save button

Screenshots

bug1

@emptynick
Copy link
Collaborator

I'm quite sure this will be fixed in #3890

@mohamedaitbella
Copy link
Author

thank you @emptynick , should I upgrade to 1.x or what ??

@fletch3555
Copy link
Collaborator

1.x is a branch used as a staging area for a future v1.2.0 release. We're planning to release it soon, but don't have a set date. I would recommend waiting for the official release.

@mohamedaitbella
Copy link
Author

thank you @fletch3555 for your prompt reply
what is your suggestion to fix this till 1.2.0 is released, should I override all my controllers or just change vendor (i know that it's a no no but the next release 1.2.0 will have the same changes ) , i have a deadline to deliver this project thanks again

@emptynick
Copy link
Collaborator

Voyager 1.2 removed Ajax validation so this shouldn't be a problem anymore.

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. If you have further questions please ask in our Slack group.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants