Attempt to fix issue #3059 #3060
Conversation
If no image is uploaded the setting’s value become null and overwrites the previous value.
| $content = $this->getContentBasedOnType($request, 'settings', (object) [ | ||
| 'type' => $setting->type, | ||
| 'field' => str_replace('.', '_', $setting->key), | ||
| 'field' => $field, | ||
| 'details' => $setting->details, | ||
| 'group' => $setting->group, | ||
| ]); | ||
|
|
There was a problem hiding this comment.
Move your condition from line 91 to line 101 and use
if ($setting->type == 'image' && $content == null)
This makes everything else unnecessary.
|
You just can push to your branch, it will update here automatically. |
|
Did the update of the pull request work? |
|
Yes it did. Also, please try to avoid committing whitespace changes (new lines, indentation/spacing changes, etc). All they do is make the diff harder to read, and make StyleCI revert them after this gets merged. I understand some IDEs do this automatically, but you can just be more selective in what you commit (e.g. you can select specific lines instead of entire files). |
|
Sorry for that! It must be php-cs-fixer, I have it set on PSR-2 but you are maybe using Symfony style? Anyway, I will try to disable it for this project. Do you have any idea if this would fix the disappearing images on the settings page? (it’s a little annoying, when the images disappear ;-)) |
|
Yep thats working |
If no image is uploaded the setting’s value become null and overwrites the previous value.