Tweaking usage of JSON "details" field

[fletch3555]

• Make sure details field is properly cast as array.
• Cleared up usage of json_encode/json_decode

[emptynick]

Missed a spot:
https://github.com/the-control-group/voyager/blob/f41031864a79c9dd3318a6eda8b6f75ffaa6110a/resources/views/posts/edit-add.blade.php#L157
And
https://github.com/the-control-group/voyager/blob/f41031864a79c9dd3318a6eda8b6f75ffaa6110a/src/Helpers/helperSlugify.php#L44

[fletch3555]

Ugh.... thanks for that. Phpunit passed locally, so I thought I had them all.

[fletch3555]

Okay, got it ALMOST passing.... Now I'm not sure how to debug this... @emptynick, would you mind trying to figure out what's going on here? https://travis-ci.org/the-control-group/voyager/jobs/443015823

Looks like it's a view trying to display a value ({{ }}), which calls out to html_special_chars(), which fails because it's an object, not a string. Almost certainly related to my details changes, but I'm not sure where we would display that value.

Also worth noting is that the helpers.php:547 in that stacktrace refers to the definition of dd(), which is super weird to me...

And finally, famous last words... it works perfectly fine on my local... (php 7.3)

[emptynick]

https://github.com/the-control-group/voyager/blob/410a54820a90c881e4a08f7ea49c5f113ee8fdda/resources/views/tools/bread/edit-add.blade.php#L301
You need to json_encode() this.

Are all conditions if (isset($row->details) still necessary?
I think if you'd check that once in your accessor, we could save a big load of those.