Fix belongsTo relationship field name.

[xikaos]

This issue was confirmed by 3 users in this issue.

Credits to @tunapiq for suggesting this fix and mine for making the PR.

[MrCrayon]

@emptynick I think it should be better to revert this commit.
This PR doesn't solve the bug because bug had nothing to do with name value used.
The problem is that with belongsTo relationship there are two rows in data_rows that try to save the value and one will be NULL, so if the second one is not the chosen one for the name used in form value will be reset to NULL.

So it doesn't matter which one we use in name as far as people know that they have to order them in a certain way.

What this PR removes is validation for belongsTo that could have been set in the field but now can't because we can't set validation rules for relationships.

Other bug #4437 as reference for the problem still happening.

[madman-81]

@MrCrayon Could this be the cause of "Not null violation" errors that I see after updating Voyager from 1.2.6 to 1.2.7?

To reproduce: I have a table/bread with a belongsTo relationship to another table/bread. When I open an existing record for editing and try to save it (so without making any changes), I'll get a "not null violation" on the belongsTo field. Note that this field had a value when I saved it.

When I downgrade to 1.2.6 and try the same steps with the same record, all works fine again.

[MrCrayon]

@madman-81 quite likely that's the reason.
You can check in your BREAD configuration if the whatever_id field comes after the relationship field than that was overwriting with NULL the value.

You can update again your platform and change fields order, that should fix it.

For more info you can check my PR #4439 and related issues linked there.

[madman-81]

@MrCrayon Yes, that has done the trick! Thanks for the quick reply.

Does your new PR fix this problem? In my opinion the order of the columns should not matter for the behaviour. Ideally you should be able to change the whatever_id field to a relationship instead of having them both in the bread configuration.

[MrCrayon]

@madman-81 yes, my PR makes the order irrilevant.
As for not having to have another field actually you can set the relationship in whatever_id details even if it's a while I don't use it that way.
Check https://voyager.readme.io/docs/relationships