Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App.js cleanup #106

Closed
wants to merge 1 commit into from
Closed

App.js cleanup #106

wants to merge 1 commit into from

Conversation

JennaDalgety
Copy link
Contributor

Ticket Number:

N/A

Describe The Problem Being Solved:

Cleanup of app.js file to remove extraneous code

Checklist For Submitter

  • I have documented all new functionality
  • I have screenshotted new UI changes and attached them to this PR

Checklist For Reviewer

  • Code formatting/static analysis: is the code formatted properly? Does a linter/other form of static analysis reveal any issues? Does the code have appropriately low cyclomatic complexity?
  • Code architecture: concerns are separated, code follows single-responsibility principle, code utilizes OOP, DRY code.
  • Coding best practices: code avoids hard-coded variables, inefficient computations, reinventing the wheel when using frameworks. Code is well-commented and generally readable.
  • Non-functional requirements: Code has accompanying tests (if using TDD). Programmer can easily explain decisions to reviewers.

@JennaDalgety JennaDalgety deleted the app_cleanup branch January 11, 2019 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant