Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text and Links Jumping While Writing #1004

Closed
nesoor opened this issue Mar 5, 2023 · 10 comments
Closed

Text and Links Jumping While Writing #1004

nesoor opened this issue Mar 5, 2023 · 10 comments
Labels
bug Something isn't working

Comments

@nesoor
Copy link

nesoor commented Mar 5, 2023

Describe the bug
When writing an email, the text jumps up and links (URLs) skip a line, even when copying and pasting a clean version of the email with no HTML or other code. This occurs when trying to place a link on the same line as the text.

To Reproduce

  1. Set up an email signature.
  2. Write a text and try to copy and paste an email address or link, attempting to place it on the same line as the text.

Expected behavior
The link should remain on the same line as the text and not jump up and down.

Screenshots
Please see attached video content.

Please complete the following information:

  • Chrome: Version 110.0.5481.178 (Official Build) (64-bit)
  • PHP version: 8.3
  • SnappyMail Version: 2.26.4
2023-03-05T22-36-13D1-33.mp4
@andreasdirscherl
Copy link

andreasdirscherl commented Mar 6, 2023

+1
Same here.

I noticed that it starts to "misbehave" after one pastes something into the message body. Even when it is plain text, no formatting.
I took a look at the HTML, and for some reason, all spaces from source text get transformed to   and then the jumping occurs. Because it suddenly is one long junk of text.
This even happens when I cut a part of the message I'm just writing and paste it elsewhere. Again, all  
Very weird.

@nesoor
Copy link
Author

nesoor commented Mar 6, 2023

+1 Same here.

I noticed that it starts to "misbehave" after one pastes something into the message body. Even when it is plain text, no formatting. I took a look at the HTML, and for some reason, all spaces from source text get transformed to   and then the jumping occurs. Because it suddenly is one long junk of text. This even happens when I cut a part of the message I'm just writing and paste it elsewhere. Again, all   Very weird.

After removing the white space beneath the text "Signature" and beginning to write or copy-paste, everything appears to function correctly.

@andreasdirscherl
Copy link

andreasdirscherl commented Mar 6, 2023

Mmh.... not for me. The   issue is what's causing it for me.
I started a brand-new message with nothing in it, no signature, no nothing. All fine until I paste something. Anything. Then the non-breaking spaces are introduced.

@nesoor
Copy link
Author

nesoor commented Mar 6, 2023

Mmh.... not for me. The   issue is what's causing it for me. I started a brand-new message with nothing in it, no signature, no nothing. All fine until I paste something. Anything. Then the non-breaking spaces are introduced.

I have the exact same issue, except that when I insert a signature, it creates an automatic white space below it. If I remove that white space first and then start writing, everything works fine.

the-djmaze pushed a commit that referenced this issue Mar 13, 2023
@andreasdirscherl
Copy link

Sorry, haven't seen this until today. I'm afraid I still experience the jumping text. Sorry.
There's also a similar new issue #1054.
It seems they are related?

@nesoor
Copy link
Author

nesoor commented Mar 24, 2023

Sorry, haven't seen this until today. I'm afraid I still experience the jumping text. Sorry. There's also a similar new issue #1054. It seems they are related?

Have you downloaded the latest version?
The latest version fixed it for me.

@andreasdirscherl
Copy link

Thanks!
Yes, I am on 2.27.2.

My issue is a little different, as it relates to introducing the   on copy and paste...

@nesoor
Copy link
Author

nesoor commented Mar 28, 2023

Thanks! Yes, I am on 2.27.2.

My issue is a little different, as it relates to introducing the   on copy and paste...

I understand what you mean, since I updated from 1.27.1. to 1.27.2 I have the same issues again.

@the-djmaze the-djmaze added the bug Something isn't working label Mar 28, 2023
@the-djmaze
Copy link
Owner

I've tested to see what is happening:

  1. Paste link
    afbeelding

  2. Backspace
    afbeelding

I've traced back this issue to the solution for #962

It seems i accidentally used container.children and not container.childNodes.
The PR i made at Squire does use container.childNodes and does not have the problem.

@andreasdirscherl
Copy link

This is great.
Thank you for all your hard work. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants