Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of messages in a folder is sometimes not being shown #1071

Closed
Zero3K opened this issue Apr 4, 2023 · 28 comments
Closed

List of messages in a folder is sometimes not being shown #1071

Zero3K opened this issue Apr 4, 2023 · 28 comments
Labels
bug Something isn't working

Comments

@Zero3K
Copy link

Zero3K commented Apr 4, 2023

Instead of the list of messages, I get an "Empty list." message every now and then.

@DerDanilo
Copy link

I can confirm this. This is happening since a few weeks. Any way how to solve this? There seem to be no errors in the logs.

@DerDanilo
Copy link

This seems to be related to the caching settings. Disabling caching or switching to file based caching will display messages again.

@the-djmaze I couldn't find any documention on how to exactly configure caching itself. The about page also doesn't check for memcache/memcached php extension.

The following issue mentions 'tcp://...'. Is this something we have to put into the config?

#113

Thanks!

@the-djmaze
Copy link
Owner

Could be related to #1096

@mmallejac
Copy link

One of my user as also reported this to me yesterday.
Sorry, no logs to add here, I've told the user to let me know about it sooner next time.
From what he said, could me similar to #998

@Zero3K
Copy link
Author

Zero3K commented May 8, 2023

bump

@the-djmaze
Copy link
Owner

Yes, still investigating 😉

@Drumsk8
Copy link

Drumsk8 commented May 30, 2023

I am having this issue with my inbox, I know my inbox is fine in roundcube/outlook/android mail. It's not all folders within my inbox either, it's the main inbox folder and some subfolders, some other subfolders show correctly. Most users it's fine, but the odd user like me or the odd folder just wont load the mail.

I've tried messing with cache settings, it's not helped me at least.

@Zero3K
Copy link
Author

Zero3K commented May 31, 2023

All that commit does is display an error message instead of "Empty list".

@the-djmaze
Copy link
Owner

All that commit does is display an error message instead of "Empty list".

Correct, then we at least know why it fails and then investigate further

@Zero3K
Copy link
Author

Zero3K commented Jun 5, 2023

I am getting aborted and timed out messages when switching between pages.

@the-djmaze
Copy link
Owner

How quick?
As the timeout is 60 seconds.

this.request('MessageList',
fCallback,
params,
60000, // 60 seconds before aborting
sGetAdd
);
}

@Zero3K
Copy link
Author

Zero3K commented Jun 6, 2023

Less than that amount of time.

@Drumsk8
Copy link

Drumsk8 commented Jun 6, 2023

Ok so now mine is saying: Can't get message list.

@the-djmaze
Copy link
Owner

Less than that amount of time.

Is it around 30 seconds?

This was referenced Jun 8, 2023
@Zero3K
Copy link
Author

Zero3K commented Jun 8, 2023

I just quickly flip between pages (like around a second or so).

@the-djmaze
Copy link
Owner

I just quickly flip between pages (like around a second or so).

Then indeed the current request gets aborted and shows aborted messages.
It will then start a new request to get the new messageslist.

Timeout occurs when browser stops the request. The only control we have (and try, but will not always work) is shown above with the 60 seconds.

In the past it just showed "aborted", then it showed nothing, and now it shows one of the two errors.

@Zero3K
Copy link
Author

Zero3K commented Jun 8, 2023

It's weird that it doesn't happen all the time.

@the-djmaze
Copy link
Owner

Not that weird. When messagelist is cached the response is in ms, else it could take ages based on IMAP server speed.

@the-djmaze
Copy link
Owner

I am on to something!
There seems to be an issue with multiple requests and timeouts

@the-djmaze the-djmaze added the bug Something isn't working label Jun 12, 2023
@the-djmaze
Copy link
Owner

the-djmaze commented Jun 12, 2023

Here we go. I've tested with the very slow Hotmail to find these.

There were multiple MessageList requests active at the same time.
Due to the async nature some got aborted and others timeout.
After testing, the above change should reduce the amount of issues and stop multiple requests at the same time.

@Zero3K
Copy link
Author

Zero3K commented Jun 12, 2023

Please provide a new version that contains this fix so I and others can test it.

@the-djmaze
Copy link
Owner

the-djmaze commented Jun 12, 2023

It's not perfect yet, as some other conditions might still have issues, like:

  1. Load messages
  2. Abort
  3. Load other messages
  4. Messages loaded
  5. Abort signal is now triggert

So i'm thinking to write a messages queue where the next is only called after finish/abort/timeout only.
But it is tricky to test and implement and probably almost never needed.

the-djmaze pushed a commit that referenced this issue Jun 13, 2023
@Zero3K
Copy link
Author

Zero3K commented Jun 13, 2023

Is there any more work to be done?

@the-djmaze
Copy link
Owner

I don't think so, but will do.some more testing.

@Drumsk8
Copy link

Drumsk8 commented Jun 14, 2023

My inbox still doesn't show. Again other inboxes are fine. Mine is fine with other tools.

I do see this error a lot in my nextcloud log:

stream_socket_client(): Unable to connect to tcp://127.0.0.1:6379 (Connection refused) at /var/www/mywebsite/public_html/apps/snappymail/app/snappymail/v/2.28.1/app/libraries/Predis/Connection/StreamConnection.php#94

@Zero3K
Copy link
Author

Zero3K commented Jun 16, 2023

I think releasing a new version would be fine then.

@the-djmaze
Copy link
Owner

I think releasing a new version would be fine then.

https://github.com/the-djmaze/snappymail/releases/tag/v2.28.2

@Zero3K
Copy link
Author

Zero3K commented Jun 22, 2023

I have tried doing what caused it in the previous version. The newest version no longer has this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants