Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextcloud 26 - CSS seems wrong #1138

Closed
celogeek opened this issue May 21, 2023 · 10 comments
Closed

Nextcloud 26 - CSS seems wrong #1138

celogeek opened this issue May 21, 2023 · 10 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@celogeek
Copy link

The CSS of the composer seems wrong on nextcloud 26

To Reproduce
Steps to reproduce the behavior:

  1. Go to SnappyMail on Nextcloud
  2. Click on New Message

Expected behavior
It would be great if the look and feel is closer to the not integrated version.

Screenshots
Capture d’écran 2023-05-21 à 16 20 02

Please complete the following information:

  • Browser: Arc Browser
  • IMAP daemon: dovecot
  • PHP version: 8.2.6
  • SnappyMail Version: 2.27.3
  • Mode: nextcloud

Additional questions
What are the expected composer screen ?
Did I miss something in my configuration ?

@the-djmaze
Copy link
Owner

Should be solved in next release.

@celogeek
Copy link
Author

How can I test it ? can I use master branch and build the nextcloud plugin ?

@celogeek
Copy link
Author

I'm trying to clone the project then:

yarn
php release.php --nextcloud

@celogeek
Copy link
Author

I generate cert in $HOME/.nextcloud/certificates

openssl genrsa -out snappymail.key 2048
openssl req -new -key snappymail.key -x509 -days 999 -out snappymail.crt

@celogeek
Copy link
Author

Ok finally I manage to install master.

here the result:
Capture d’écran 2023-05-27 à 12 00 19

It's way better.
Still need some works on the size of the button, they are not equal.
Select and Button have different size.

@celogeek
Copy link
Author

well, I can't send mail anymore:

When I try to do the test it log this:

Call to undefined method MailSo\Smtp\SmtpClient::logMask()

@celogeek
Copy link
Author

celogeek commented May 27, 2023

Found it, some signal capture lead to

May 27 12:25:36 nextcloud nginx[64]: 2023/05/27 12:25:36 [error] 64#64: *40037 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Error installing signal handler for 19 in /app/apps/snappymail/app/snappymail/v/2.27.3/app/libraries/MailSo/Log/Logger.php on line 78; PHP message: PHP Fatal error:  Error installing signal handler for 19 in Unknown on line 0" while reading response header from upstream, client: IP, server: _, request: "GET /apps/snappymail/ HTTP/1.1", upstream: "fastcgi://unix:/run/php-fpm/php-fpm.sock:", host: "mydomain"

I comment in the Logger those signal:

  • SIGCONT
  • SIGINT
  • SIGKILL
  • SIGSTOP

@celogeek
Copy link
Author

diff --git a/snappymail/v/0.0.0/app/libraries/MailSo/Log/Logger.php b/snappymail/v/0.0.0/app/libraries/MailSo/Log/Logger.php
index caaaace65..47386efe4 100644
--- a/snappymail/v/0.0.0/app/libraries/MailSo/Log/Logger.php
+++ b/snappymail/v/0.0.0/app/libraries/MailSo/Log/Logger.php
@@ -32,14 +32,14 @@ class Logger extends \SplFixedArray
                'SIGBUS',
                'SIGCHLD',
                'SIGCLD',
-               'SIGCONT',
+//             'SIGCONT',
                'SIGFPE',
                'SIGHUP',
                'SIGILL',
 //             'SIGINT',
                'SIGIO',
                'SIGIOT',
-               'SIGKILL',
+//             'SIGKILL',
                'SIGPIPE',
                'SIGPOLL',
                'SIGPROF',
@@ -47,7 +47,7 @@ class Logger extends \SplFixedArray
                'SIGQUIT',
                'SIGSEGV',
                'SIGSTKFLT',
-               'SIGSTOP',
+//             'SIGSTOP',
                'SIGSYS',
                'SIGTERM',
                'SIGTRAP',

the-djmaze pushed a commit that referenced this issue May 27, 2023
the-djmaze pushed a commit that referenced this issue May 27, 2023
@the-djmaze
Copy link
Owner

Thanks! I made your changes

@celogeek
Copy link
Author

this is great.

Capture d’écran 2023-05-29 à 09 13 33

It would be excellent when you merge on master to create a beta release.
So we can may be have an easy way to take the beta version from nextcloud.

I will close this issue, as it's fixed for me.

@the-djmaze the-djmaze added enhancement New feature or request bug Something isn't working labels May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants