Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in email signature editor #1339

Closed
MarcouxDesBois opened this issue Nov 30, 2023 · 3 comments
Closed

Bug in email signature editor #1339

MarcouxDesBois opened this issue Nov 30, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@MarcouxDesBois
Copy link

MarcouxDesBois commented Nov 30, 2023

Describe the bug
When i want to add an email signature with html, the editor transform the code to include some <div></br></div> even it's not necessary. The result is a signature with large space between elements.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Settings - Accounts - Identitie'
  2. Click on your mail
  3. Insert html code in the editor (on source)
  4. Change the layout to see a render with html view
  5. See error

Expected behavior
HTML code should not have unwanted spaces.

Screenshots
Result i have :
image

Please complete the following information:

  • Browser: chromium 119.0.6045.159
  • SnappyMail Version: 2.29.4
  • Mode: nextcloud

Debug/logging information
I haven't log.

@the-djmaze
Copy link
Owner

3. Insert html code in the editor (on source)

We need the HTML code, else we have no idea why it fails.

@the-djmaze the-djmaze added the needs feedback Further information is requested label Nov 30, 2023
@MarcouxDesBois
Copy link
Author

Oh sorry !

This is the html :

<table style="font-size: medium; font-family: Arial,serif;">
    <tr>
        <td>
            <img src="https://babel.coop/wp-content/uploads/2021/03/logo-babel-simple.jpg" role="presentation"
                 width="130" style="max-width: 130px;" alt="logo">
        </td>
        <td style="vertical-align: middle;">
            <h2 color="#2B7CC3" style="margin: 0px; font-size: 18px; color: rgb(43, 124, 195); font-weight: 600;">
                <span>username</span>
            </h2>
            <p color="#2B7CC3"
               style="margin: 0px; font-weight: 500; color: rgb(43, 124, 195); font-size: 14px; line-height: 22px;">
                company
            </p>
        </td>
        <td>
            <div style="width: 5px;"></div>
        </td>
        <td color="#f2547d" direction="vertical" height="auto"
            style="width: 1px; border-bottom: none; border-left: 1px solid rgb(242, 84, 125);">
        </td>
        <td>
            <div style="width: 5px;"></div>
        </td>
        <td style="vertical-align: middle;">
            <table>
                <tbody>
                <tr>
                    <td>
                        <a href="tel:0607080910" color="#2B7CC3"
                           style="text-decoration: none; color: rgb(43, 124, 195); font-size: 12px; padding: 0px">
                            0607080910
                        </a>
                    </td>
                <tr>
                    <td>
                        <a href="mailto:mail@ma.il" color="#2B7CC3"
                           style="text-decoration: none; color: rgb(43, 124, 195); font-size: 12px;">
                            mail@ma.il
                        </a>
                    </td>
                </tr>
                <tr>
                    <td>
                        <a href="//www.site.com" color="#2B7CC3"
                           style="text-decoration: none; color: rgb(43, 124, 195); font-size: 12px;">
                            www.site.comm
                        </a>
                    </td>
                </tr>
                </tbody>
            </table>
        </td>
    </tr>
</table>

@the-djmaze the-djmaze added bug Something isn't working and removed needs feedback Further information is requested labels Dec 1, 2023
@MarcouxDesBois
Copy link
Author

Thank you for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants