Issue when using the enter key in a reply window

[mmallejac]

Using the enter key in a reply window, to start a new line has a strange behavior: sometimes it works, sometimes it jumps one extra lines, sometimes 2, and sometimes even it puts the cursor somewhere inside the signature.
Is has been verified with Firefox and Brave, within 2 different Nextcloud instances.

We use Snappy 2.29.1 within Nextcloud 27.1.2

Thanks in advance for your help !

[mmallejac]

See this little video that illustrates the bug, where the issue happens 2 times:

• at "two": I press Enter, but the cursor comes back to previous line)
• at "six": I press Enter once, but the cursor goes at the end of the message

snappyReplyBug.mp4

[andreasdirscherl]

+1
Exactly the same for me.

[the-djmaze]

Maybe related to #1339 where Squire added a <div><br></div> everywhere.
So check when v2.30 is released

[mmallejac]

Hello ! Thanks for this.
I've upgraded to the latest version 2.30
Unfortunately still buggy

See the attached video : I've installed screenkey so that you can see what I am typing exactly.
Bugs at lines 1 and 4

Also attached a screenshot of the debugger tool :

231204.Snappy.mp4

Another suggestion : maybe it could be nice / useful to have the About tab present not only within the Snappymail Config panel, but also while using it ? (in the Parameters section)
(as I wanted to be sure that I was using the latest version 2.30)

Hope this helps !
Cheers,

[the-djmaze]

Please test my changes at https://snappymail.eu/demo/

[mmallejac]

Looking great ! I've done multiple replay test, I couldn't see any problem I've switched to the Nextcloud25+ just to be sure, and I was using the same Firefox. 👍 Le lun. 4 déc. 2023 à 17:46, the-djmaze ***@***.***> a écrit :

…

Please test my changes at https://snappymail.eu/demo/ — Reply to this email directly, view it on GitHub <#1296 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACZAG2LXCZI3KQ6KOGT63XDYHX46FAVCNFSM6AAAAAA6WTSGN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZZGA2DMNZUGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[andreasdirscherl]

I can confirm that the behavior persists in version 2.30.
Aldo did a test run on the demo account, and here all seems to work perfectly. Like Michel had already said. Fingers crossed!

Are we sure that is not something weird that Nextcloud introduces for snappymail? Similar to not being able to update snappymail through Nextcloud admin?
I'm on the latest Nextcloud version btw - Nextcloud Hub 6 (27.1.4)

At any rate, thanks @the-djmaze for all the hard work!

[the-djmaze]

It is Firefox.
Around Firefox 77 the cursor was gone and they fixed that.
But now Firefox has trouble when we set the Range and Selection in JavaScript.
Firefox reverts to the old Range selection.

It must be something in Squire and currently the demo skips the code that handles the Enter key.
Drawback is that <br> is not handled by Squire.

[andreasdirscherl]

OMG! You are a hero.
Just tried Chromium and yes, no cursor jumping around!
In a million years would I have thought of it being a browser issue. My beloved Firefox.
You would think that JavasScript should be handled correctly in all modern browsers... Alas...
Thanks for getting to the bottom of this!

[mmallejac]

Yes, many thanks Are you aware of some kind of Firefox fix for this ? Le mar. 5 déc. 2023 à 13:33, Andreas Dirscherl ***@***.***> a écrit :

…

OMG! You are a hero. Just tried Chromium and yes, no cursor jumping around! In a million years would I have thought of it being a browser issue. My beloved Firefox. You would think that JavasScript should be handled correctly in all modern browsers... Alas... Thanks for getting to the bottom of this! — Reply to this email directly, view it on GitHub <#1296 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACZAG2JFUHUXW2DBIZFHW3LYH4H73AVCNFSM6AAAAAA6WTSGN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBQG4YDMOBXGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[the-djmaze]

Firefox bug:

if you set the Selection Range in the text node after the new line, it draws the cursor before the line break.

Squire:

Set the this._recordUndoState(range) which creates a hidden bookmark <input>
But this fails due to inUndoState == true

Workaround: force a _docWasChanged()

Real solution: TODO = find out why _docWasChanged() is not triggered at all