Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read Receipts Reference Main Account Email, Not Identities #147

Closed
electroflame opened this issue Sep 24, 2021 · 3 comments
Closed

Read Receipts Reference Main Account Email, Not Identities #147

electroflame opened this issue Sep 24, 2021 · 3 comments

Comments

@electroflame
Copy link

electroflame commented Sep 24, 2021

Describe the bug
When using read receipts and/or delivery receipts, the Disposition-Notification-To and X-Confirm-Reading-To headers use the main account email instead of the designated identity. Not only is this confusing to the recipient to see a different email in the read receipt request, it exposes the mail account email (which, if you're using an identity, is likely undesirable).

To Reproduce
Steps to reproduce the behavior:

  1. Compose mail and select read receipt and/or delivery receipt.
  2. Send mail to some other email account you can view.
  3. Verify headers, or check the read receipt notification popup.

Expected behavior
The sender account identity should be used for both headers instead, to maintain consistency (not confuse the sender), and to preserve privacy.

Additional context
This seems to be a long-standing issue with Rainloop, as when I was researching this I found references as far back as 2016. As far as I can tell, there isn't a legitimate reason for this to happen, so I think it's a bug, not a feature. 😉

@electroflame electroflame changed the title Read Receipts Reference Main Account Email, Not Identites Read Receipts Reference Main Account Email, Not Identities Sep 24, 2021
the-djmaze pushed a commit that referenced this issue Sep 27, 2021
@the-djmaze
Copy link
Owner

Does the above change resolve your issue?

@electroflame
Copy link
Author

electroflame commented Sep 27, 2021

I just updated that line in my install and it seems to have done the trick, thanks!

Additionally, it might be a nice UI improvement to not have the extra hamburger menu automatically close when a checkbox is clicked. If you want to click more than one box (i.e. read receipt and delivery receipt) you end up having to open the hamburger menu multiple times.

However this issue seems fixed. If you want to pursue the additional UI improvement I can open a separate issue for it, if you'd rather have a record of it.

Thanks for the quick commit!

@the-djmaze
Copy link
Owner

Great it solved it.

Problem with the menu closing is that it is based on the old default "registerBootstrapDropdown".
Bootstrap has a feature to always close a menu when you click somewhere (inside and outside the menu).
You could report it as separate issue, but changing/solving it would require important changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants