Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control-a in search input selects emails instead of text #277

Closed
terribleplan opened this issue Mar 8, 2022 · 3 comments
Closed

Control-a in search input selects emails instead of text #277

terribleplan opened this issue Mar 8, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@terribleplan
Copy link

Describe the bug
When editing the search field (input is the active element) pressing Control+a selects all emails instead of the text in the field.

To Reproduce

  1. Type something into the search field
  2. Press Control+a
  3. See that email are selected instead of text in search field

Expected behavior
The text in the search field is selected

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • Firefox 97
  • SnappyMail 2.13.3

Additional context
Possibly related to the underlying cause of #265, but was seemingly not fixed when that was.

@the-djmaze
Copy link
Owner

Possibly related to the underlying cause of #265, but was seemingly not fixed when that was.

Correct, i missed that one

@terribleplan
Copy link
Author

terribleplan commented Mar 11, 2022

@the-djmaze I think there's the same issue for the space bar as well. If a mail is open it selects the checkbox for it, or does nothing if there is no open mail on the right pane.

I wonder if it would be possible to just prevent the key events from propagating beyond the input or disable shortcuts/commands while the input is focused.

the-djmaze pushed a commit that referenced this issue Mar 11, 2022
@the-djmaze
Copy link
Owner

@terribleplan thanks for finding that one.

I know these bugs suck, but eventually we get there the right way :)

@the-djmaze the-djmaze added the bug Something isn't working label Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants