Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextcloud theme is dark by defualt while the user theme is Light #620

Closed
elhananjair opened this issue Nov 3, 2022 · 6 comments
Closed
Labels
bug Something isn't working external Issue is outside our code Nextcloud

Comments

@elhananjair
Copy link

Describe the bug
I have a light theme applied on nextcloud, and I selected Nextcloud theme snappymail setting. By default, it is dark, but currently I am using Light theme therefore it doesn't look nice.

To Reproduce
Steps to reproduce the behavior:

  1. Go to setting
  2. Click on themes
  3. Select Nextcloud from the theme list
  4. The dark background color appears

Expected behavior
Should be the same with Nextcloud applied theme

Screenshots
Screenshot from 2022-11-03 23-28-38
Please complete the following information:

  • Browser: Firefox 106
  • IMAP daemon: [e.g. courier, dovecot]
  • PHP version: 8.0.25
  • SnappyMail Version: 2.20

Debug/logging information
Place them here (few lines) or as attachments (many lines)

Additional context
Add any other context about the problem here.

@the-djmaze
Copy link
Owner

SnappyMail 2.20 uses var() settings in CSS of your theme.
So your theme might have issues.

Try Nextcloud default or Breeze Dark.

Also report which Nextcloud theme you are using.

@elhananjair
Copy link
Author

@the-djmaze as you might see in the pic am using Nextcloud theme on snappy mail and the Light theme on Nextcloud.

@the-djmaze
Copy link
Owner

Right. Where do you set the default to Dark?
Because i can't find that option in my Nextcloud

@the-djmaze
Copy link
Owner

Did you try the embed mode?

@the-djmaze
Copy link
Owner

the-djmaze commented Nov 4, 2022

Ah, you are using Nextcloud 25.
Because everything works fine in Nextcloud 24.

So i went and installed Nextcloud 25 and i noticed that the theme of NC25 is horrible.

You should report to Nextcloud that there is something wrong with the :root variables.

Because SnappyMail just maps its own variables to that of Nextcloud. Like:

:root {
	--main-bg-color: var(--color-main-background)
}

But --color-main-background is black, not white in NC25

The issue is the way how NC25 controls theme colors

[data-theme-light] {
	--color-main-background: #fff;
}

@the-djmaze the-djmaze added bug Something isn't working external Issue is outside our code Nextcloud labels Nov 4, 2022
@the-djmaze
Copy link
Owner

Fixed in v2.20.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external Issue is outside our code Nextcloud
Projects
None yet
Development

No branches or pull requests

2 participants