Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUTinICS calendar not recognized #661

Closed
Bolli84 opened this issue Nov 12, 2022 · 13 comments
Closed

PUTinICS calendar not recognized #661

Bolli84 opened this issue Nov 12, 2022 · 13 comments
Labels
bug Something isn't working external Issue is outside our code Nextcloud workaround

Comments

@Bolli84
Copy link

Bolli84 commented Nov 12, 2022

Referencing existing issue but with new calendar content:

Reopen with the following calendar:

BEGIN:VCALENDAR
VERSION:2.0
PRODID:www.ccccc.dd
METHOD:PUBLISH
BEGIN:VEVENT
UID:20221112T093211-www.dddddddd.ed
ORGANIZER;CN=xxxxxx, xx<:MAILTO:info@cccccc
LOCATION:xxxxxx
SUMMARY:Reservierung
DESCRIPTION:Buchungs-Nr.: 1006341
 \nDatum / xxx: 13.11.2022 / 09:00
  \nloc: 12 4444444445
   \ngame 1: sadsadasdsa, w:y 
CLASS:PUBLIC
DTSTART:20221113T090000
DTEND:20221113T130000
DTSTAMP:20221112T093211
END:VEVENT
END:VCALENDAR

Originally posted by @Bolli84 in #622 (comment)

@the-djmaze
Copy link
Owner

That's a strange format.
Not only the \n but also the spaces in front of them.

Is this really correct?

@Bolli84
Copy link
Author

Bolli84 commented Nov 14, 2022

Yes, it is an used format for booking into Reservations at hotels, restaurants, gamespace bookings over many simple websites.

This is just a very abbreviated form but shows all relevant content.

@the-djmaze
Copy link
Owner

Ok, this is a Nextcloud bug.
Nextcloud Calendar requires ATTENDEE and your file has none.
nextcloud/calendar#4684

But according to RFC 5545 section 3.6.1:

; The following are OPTIONAL, and MAY occur more than once.
attach / attendee / categories / comment /
contact / exdate / rstatus / related /
resources / rdate / x-prop / iana-prop

Yes your file is valid, problem is Nextcloud

@Bolli84
Copy link
Author

Bolli84 commented Nov 14, 2022

Does snappymail recignize the calendar-file to be imported?

The calendar can be imported by nextcloud calendar directly quire easy. But it should be recognized first

@the-djmaze
Copy link
Owner

The calendar can be imported by nextcloud calendar directly quire easy.

How?

I only found the PUT command and that crashes the Calendar app.

@Bolli84
Copy link
Author

Bolli84 commented Nov 14, 2022

With the PUT into the webdav calendar as well as ther direct IMPORT into the calendar by opening the Calendar and importing it with the lower left corner

@the-djmaze
Copy link
Owner

the-djmaze commented Nov 14, 2022

Ok, then they probably modify the ICS file to fit their needs.
I just PUT as-is.

I'm not going to modify ICS because then we are bound to Nextcloud Calendar quirks, updates, bugs, etc.

There should be a different way.

@Bolli84
Copy link
Author

Bolli84 commented Nov 14, 2022

Just as I did with old rainloop. Only PUT it.

@the-djmaze
Copy link
Owner

the-djmaze commented Nov 14, 2022

@Bolli84 that's what the code does.
Exactly the same, so something else is going on.

Maybe line endings CRLF vs LF, maybe something else.

@the-djmaze
Copy link
Owner

the-djmaze commented Nov 15, 2022

I've tested and tested and tested.
The problem really is Nextcloud and i can't do anything about it.

When an .ics file contains ATTENDEE or ORGANIZER, Nextcloud Calendar 4.1.0 keeps crashing on me.

When i remove all ATTENDEE and ORGANIZER properties of the .ics, the import succeeds.

I even tried the import function of Nextcloud Calendar itself and it still keeps crashing, so it really has nothing to do with SnappyMail

@the-djmaze the-djmaze added bug Something isn't working external Issue is outside our code Nextcloud workaround labels Nov 15, 2022
@Bolli84
Copy link
Author

Bolli84 commented Nov 15, 2022

My point is the following:

On many other calendars, the button: "Put in Calendar" appears in snappymail to include it. The given calendaritem does not show this in snappymail. It allows me to download it.

So, this is not even at the point to IMPORT it still for me.

@the-djmaze
Copy link
Owner

the-djmaze commented Nov 15, 2022

Admin -> Extensions -> Nextcloud cog wheel to enable

@Bolli84
Copy link
Author

Bolli84 commented Nov 17, 2022

No, does not work.

Can I send you my calendar-mail i got for you to try?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external Issue is outside our code Nextcloud workaround
Projects
None yet
Development

No branches or pull requests

2 participants