-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CardDAV sync does not work #79
Comments
DAV[DATA]: PROPFIND /.well-known/carddav INFO[NOTICE]: SnappyMail\HTTP\Exception: 301 Moved Permanently
It crashes on the redirect
I've modified the dav client to log where it wants to go.
My Synology redirects to |
It would be great if you could allow that, because I've tried to sync with Nextcloud and Nextcloud shows a warning, if well-known/carddav is not configured. |
I've set the max redirects to 1 for this case. This will open a security hole when the redirect goes to a different server that listens for 401 status to login. |
Modified to secure it to same host |
Ok, great! I would be happy to test again (but only in the evening), if you could build an RC2. |
Thanks! I will create RC2 https://github.com/the-djmaze/snappymail/releases/tag/v2.5.0-rc.2 |
Just tested the RC2. Now I get the following error: |
I've just applied your patch and now get the following error: |
I'm getting this (on v2.5.0-rc.2 without the patch above): Logs "grepped" with "dav":
Also, the "hamburger" icon changes to a line and spins out of its designated area :) [edit] Just applied the patch and logs look pretty much the same, except this changed:
|
This is annoying. PROPFIND is not allowed so i'm clueless what is allowed. So i've made a change to see if that improves logging. |
I did a test on https://demo2.nextcloud.com
Response is:
It seems there are bugs in NextCloud because the response is wrong. So i'm improving error logging for this behaviour |
RC3 logs:
|
Yes, i've figured it out! |
That's some commit(ment) there. I'll see if I can verify this tonight. |
Copy/merge my code with other people code somehow opened a lot of bugs. Found RainLoop, NextCloud, Synology and mine, so i hope most are solved! |
Much appreciate your work! |
I pulled the 2 changed file and the new file from your commit above and i though it worked again. No error. But when I now open my contacts there are none (zero, nothing, null) contacts anymore. There are still in my CardDAV thank god :) Just to be sure, I also checked the commit at RainLoop#2089 but those changes seem to have moved to the new CardDAV.php so I kept the PdoAddressBook.php from the commit above. |
@ervee i know 😢 So again i made changes to remove array_change_key_case() and fix the code again. And moved back registerXPathNamespace() because it has issues with default namespace on Synology. |
carddav.log |
@phsc84 I've also noticed an issue in AddressBook where it was looking for \class_exists('Sabre\DAV\Client') while it should not. I get:
|
Next try with RC4. |
I've applied your latest 2 commits manually. Now the synchronization does not interrupt anymore. But it still does not work (see log and screenshot). |
Tested and now fully working on demo1.nextcloud.com |
Again, I've applied your patches manually (I do not know, how to build a release). Now it works like a charm! The spinner is also beautiful! |
Describe the bug
CardDAV sync does not work
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Contacts are synchronised and stored in the database.
Desktop (please complete the following information):
Browser: Google Chrome 89, 64-bit
SnappyMail: 2.5.0-RC1
Additional context
error.log
The text was updated successfully, but these errors were encountered: