-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The attached email causes a request failed message to be displayed #972
Comments
What was the issue? |
SVG elements were not stripped. |
What is wrong with SVG elements? There should be a way to support them instead of removing them. |
When someone writes emails, they should always check what is possible. SnappyMail removes SVG for reasons. |
The majority of the webmail providers listed on it support SVG. |
But not Gmail and Gmail is big... |
I think you should be better than Gmail since even other small webmail providers support it. And it will give people another reason to use a SnappyMail based provider over Gmail. |
HTML5, SVG, MathML, etc. etc. have many different elements and element attributes. The current purpose of cleanHTML is to support where possible, but remove security related things like javascript, tracking pixels, etc. etc. SVG would open new security issues and needs special handling with a tree walker and more. Why overload parsing when it is already slow in your 2MB email? What if you paste an SVG in the editor but recipient can't see it? There are just so many expectations by people who don't understand why things don't work, that it is better to not support it at all. Same with dark mode and people sending emails with text color black but not defining background color white.
Why should we fix screwups of others? I use Kmail on PC in dark mode and some emails are not readable due to the mess people send to me. Patreon could just have put the SVG as inline attachment and then an img element with a cid to that attachment and it will work. |
So, I should suggest that fix to them? |
Sure, go ahead. Maybe they will change it. |
I have messaged their Twitter account regarding it. I will let you know their response when it I get it. |
Can it be done even though it is not using a .svg file hosted on one of their server(s)? |
Yes that would work the same. |
Oh here's another issue:
That's why Microsoft is pushing Office365 web apps 😝 |
subject
messages-20230216141957.zip
The text was updated successfully, but these errors were encountered: