Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab key selects toolbar buttons #98

Closed
electroflame opened this issue Jul 13, 2021 · 2 comments
Closed

Tab key selects toolbar buttons #98

electroflame opened this issue Jul 13, 2021 · 2 comments

Comments

@electroflame
Copy link

Is your feature request related to a problem? Please describe.
Currently, if you use Tab to move from text field to text field, you end up having to tab over the various toolbar buttons.

Describe the solution you'd like
Ideally, after the last text field, it should jump directly to the text area containing the email's contents.

Looking at it, I see two relatively pain-free ways to handle this:
1.) Assign the tabindex attribute to the non-textfield toolbar buttons, and set it to -1 (i.e. never selectable via tab).
2.) Assign positive tabindex values to the text fields and text areas.

Given that there is some dynamic element to what text fields are displayed (i.e. some can be added by clicking the CC, BCC, etc. buttons) I think that the first option is probably the cleanest.

Describe alternatives you've considered
Alternatively, this might be a configuration option, as I could potentially see someone wanting to change font-size or something via the keyboard, but overall I think this is likely a bug.

Additional context
Looking at it further (and after comparing RainLoop and SnappyMail), this might just be a regression from switching CKEditor to Squire, as RainLoop handles skipping over the toolbar buttons correctly.

@electroflame
Copy link
Author

electroflame commented Jul 14, 2021

After further investigation, this doesn't occur if the CKEditor plugin is used (the toolbar is skipped over), so this looks more like a regression related to switching to Squire.

However, when using the CKEditor plugin, the Content/Attachment buttons still get selected via tab before jumping down into the email text area, so it's not a perfect alternative (although it is an improvement).

the-djmaze pushed a commit that referenced this issue Jul 14, 2021
@the-djmaze
Copy link
Owner

Resolved the issue with tabindex="-1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants