Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't remove ACL allow (org.matrix.mjolnir.allow ) when unbanning #56

Open
Mikaela opened this issue Jun 8, 2023 · 0 comments
Open

Don't remove ACL allow (org.matrix.mjolnir.allow ) when unbanning #56

Mikaela opened this issue Jun 8, 2023 · 0 comments
Labels
L1 Very Few Likelihood P1 Nuisance Priority level T4 Minor usability Impairs usability in secondary scenarios.

Comments

@Mikaela
Copy link
Member

Mikaela commented Jun 8, 2023

Currently !draupnir unban removes all matching rules including explicit allow such as

{
  "entity": "*",
  "reason": "Default allow rule",
  "recommendation": "org.matrix.mjolnir.allow"
}

Resulting into somewhat unforeseen consequences 馃槄

Originally reported at matrix-org/mjolnir#482
Gnuxie added a commit that referenced this issue Sep 1, 2023
@Gnuxie
Some safety around ACL allows.
4d657ec 
Related: #56.
@Gnuxie Gnuxie mentioned this issue Sep 1, 2023
Closed
Gnuxie added a commit that referenced this issue Sep 5, 2023
@Gnuxie
Some safety around ACL allows.
2b97f33 
Related: #56.
@Mikaela Mikaela added L1 Very Few Likelihood P1 Nuisance Priority level T4 Minor usability Impairs usability in secondary scenarios. labels Dec 31, 2023
Mikaela added a commit to Mikaela/gist that referenced this issue Jan 31, 2024
@Mikaela
matrix/m.policy.rule.server: warn about the-draupnir-project/Draupnir#56
b07fac0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
L1 Very Few Likelihood P1 Nuisance Priority level T4 Minor usability Impairs usability in secondary scenarios.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Mikaela