Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional fields import for Venues and Organizers #4314

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Add additional fields import for Venues and Organizers #4314

wants to merge 14 commits into from

Conversation

andrasguseo
Copy link
Contributor

@andrasguseo andrasguseo commented Jun 30, 2023 •
edited by jira bot

Add filter and logic to handle the saving of additional data for Organizers and Venues when doing a CSV import.

TEC-4846

@andrasguseo
Add filter and logic to handle the saving of additional data for orga…
4c58030 
…nizers

The code block is a copy-paste from Events.
An extra line is added for handling the removal of a prefix.
@andrasguseo
Fixing typos
e4ceace
@andrasguseo
Add filter and logic to handle the saving of additional data for venues
67a1d97 
The code block is a copy-paste from Events.
An extra line is added for handling the removal of a prefix.
@andrasguseo
Fixing typos
fa6eaf0
@andrasguseo
Update readme.txt
24881ea
@andrasguseo andrasguseo requested a review from Camwyn June 30, 2023 19:47
@Camwyn Camwyn added the needs release Needs an associated release in Jira before merging. label Jul 12, 2023
Camwyn
Camwyn requested changes Jul 17, 2023
View reviewed changes
Copy link
Member

@Camwyn Camwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some docblock tweaks, otherwise 👨🏼‍🍳

readme.txt Outdated Show resolved Hide resolved
src/Tribe/Importer/File_Importer_Organizers.php Outdated Show resolved Hide resolved
src/Tribe/Importer/File_Importer_Venues.php Outdated Show resolved Hide resolved
src/Tribe/Importer/File_Importer_Venues.php Outdated Show resolved Hide resolved
src/Tribe/Importer/File_Importer_Organizers.php Outdated Show resolved Hide resolved
@Camwyn Camwyn changed the title Enhancement/btria 1908 Add custom fields import for Venues and Organizers Jul 17, 2023
@Camwyn Camwyn changed the title Add custom fields import for Venues and Organizers Add additional fields import for Venues and Organizers Jul 17, 2023
andrasguseo and others added 6 commits July 21, 2023 10:21
@andrasguseo @Camwyn
Adjust changelog to adhere to gudielines
ce5cabb 
Co-authored-by: Stephen Page <stephen@theeventscalendar.com>
@andrasguseo @Camwyn
Adjust var description in DocBlock
9ab1f31 
Co-authored-by: Stephen Page <stephen@theeventscalendar.com>
@andrasguseo @Camwyn
Adjust var description in DocBlock
934b4fe 
Co-authored-by: Stephen Page <stephen@theeventscalendar.com>
@andrasguseo @Camwyn
Dev comment tweak
188ea42 
Co-authored-by: Stephen Page <stephen@theeventscalendar.com>
@andrasguseo @Camwyn
Dev comment tweak
3169917 
Co-authored-by: Stephen Page <stephen@theeventscalendar.com>
@andrasguseo
Merge branch 'master' into enhancement/BTRIA-1908
9a28c6b
@andrasguseo andrasguseo requested a review from Camwyn July 21, 2023 08:28
@andrasguseo
Copy link
Contributor Author

@Camwyn Thanks for the code review and the feedback. So much appreciated!
There was a conflict in the readme because a release went out since the branch was created. I "tried" to resolve it, please check if I did it correctly. Thanks again!

@Camwyn Camwyn self-assigned this Aug 18, 2023
@Camwyn
Copy link
Member

Camwyn commented Aug 18, 2023

This is scheduled to go out in Sprint 32 (we're currently on 29) I'll keep it up to date until then. Self-assigning

@andrasguseo
Copy link
Contributor Author

Awesome, thanks @Camwyn !

@Camwyn Camwyn changed the base branch from master to release/B23.maria October 31, 2023 03:13
@Camwyn Camwyn changed the base branch from release/B23.maria to master November 14, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Camwyn Camwyn Awaiting requested review from Camwyn

Requested changes must be addressed to merge this pull request.

Assignees

@Camwyn Camwyn

Labels
needs release Needs an associated release in Jira before merging.
Projects
None yet
Milestone
No milestone
2 participants
@andrasguseo @Camwyn