TEC-4831 outlook timezone omitted with subscribe #4444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tec-bot
reviewed
Dec 5, 2023
Camwyn
changed the base branch from
master
to
fix/TEC-4916-filter-outlook-links
tec-bot
reviewed
Dec 6, 2023
…bscribe-outlook-timezone
Camwyn
force-pushed
the
fix/TEC-4831-subscribe-outlook-timezone
branch
from
eee75fc
to
abb0819
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TEC-4831
When using the Subscribe to Outlook on a single event page, then the event time zone is not taken into account.
This PR attempts to provide a fix for that.
This is what happens before the fix:
If there is an event with New York time zone in the calendar, and I click subscribe, then Outlook offers to save it with those original times using my Outlook time zone, which is different than New York, giving me wrong times as a result.
This is what happens with the fix:
If there is an event with New York time zone in the calendar, and I click subscribe, then Outlook will recalculate the start/end times and offers to save it with those using my Outlook time zone.
I could only test with Outlook Live and there it work.
I added a boolean filter to be able to revert back to the original functioning. Maybe that filter should be flipped.
There's some other Outlook-related fix planned in #4441. It would be a nice companion to that. 🙂