Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ET-741, PRMTR-206, TCMN-47: Promoter Listeners improvements #1311

Closed
wants to merge 25 commits into from
Closed

ET-741, PRMTR-206, TCMN-47: Promoter Listeners improvements #1311

wants to merge 25 commits into from

Conversation

mitogh
Copy link
Contributor

@mitogh mitogh commented Mar 4, 2020 •
edited by jira bot

Ticket ET-741
Ticket PRMTR-206
Ticket: TCMN-47

@mitogh mitogh added code review Status: requires a code review. needs release Needs an associated release in Central before merging. labels Mar 4, 2020
@mitogh mitogh self-assigned this Mar 4, 2020
@mitogh mitogh changed the title Spotfix/et 741 promoter listeners Promoter Listeners improvements Mar 4, 2020
@mitogh mitogh changed the title Promoter Listeners improvements ET-741, PRMTR-206, TCMN-47: Promoter Listeners improvements Mar 4, 2020
@bordoni bordoni changed the base branch from master to release/B20.03 March 5, 2020 05:58
@lucatume
Copy link
Contributor

lucatume commented Mar 5, 2020

@mitogh there's a lot of commit noise in there, was this branch forked off release/20.03?

@lucatume lucatume added question Needs an answer to one or more questions before merging. hold Status: on hold–do not proceed with other status items. labels Mar 5, 2020
@mitogh
Copy link
Contributor Author

mitogh commented Mar 5, 2020

Was based from master let me do the Merge dance to cleanup this 💃

@mitogh mitogh removed needs release Needs an associated release in Central before merging. question Needs an answer to one or more questions before merging. labels Mar 5, 2020
@mitogh
Copy link
Contributor Author

mitogh commented Mar 5, 2020

This PR requires: #1313

@mitogh mitogh removed the hold Status: on hold–do not proceed with other status items. label Mar 5, 2020
@mitogh mitogh added the needs changelog Needs a changelog entry before merging. label Mar 6, 2020
mitogh and others added 8 commits March 6, 2020 19:22
@mitogh
Replace sys_get_temp_dir with native get_temp_dir
c98a7dd 
There are several benefits in doing the change like:

- Use of constant to define the value `WP_TEMP_DIR`
- `get_temp_dir` fallback to `sys_get_temp_dir` when the function exists and check the function is present on the system
- Validations of the different directories (is writtable) before returning the value

In order to provide better support with native WordPress functions,
@bordoni
Merge pull request #1314 from moderntribe/spotfix/remove-compile-files
8935b1a 
Remove .mo files from repo as well as .min.js files
@andrasguseo @lucatume
Added context to Georgia
614c734
@lucatume
Merge pull request #1316 from moderntribe/spotfix/add-context-to-geor…
a3da082 
…gia-state

Added context to Georgia
@jesseeproductions
Merge branch 'release/B20.03' into fix/ECP-345-check-doing-filter
2c9144e
@jesseeproductions
Merge pull request #1310 from moderntribe/fix/ECP-345-check-doing-filter
b6a467a 
Fix/ecp 345 check doing filter
@mitogh
Merge branch 'release/B20.03' into spotfix/tmp_directory
0db6266
@mitogh
Merge pull request #1315 from moderntribe/spotfix/tmp_directory
ae78345 
Replace `sys_get_temp_dir` with native `get_temp_dir`
sc0ttkclark
sc0ttkclark suggested changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@sc0ttkclark sc0ttkclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changelog, but looks good!

@mitogh
Copy link
Contributor Author

mitogh commented Mar 9, 2020 •
edited

Hey @sc0ttkclark are you planning to do a release with ET for common? if so we can include this into that branch instead.

Thanks.

@sc0ttkclark
Copy link
Contributor

There are no common changes as of yet for G20.03

@mitogh mitogh removed the needs changelog Needs a changelog entry before merging. label Mar 9, 2020
@mitogh mitogh requested a review from sc0ttkclark March 9, 2020 19:57
@sc0ttkclark sc0ttkclark changed the base branch from release/B20.03 to release/G20.03 March 10, 2020 20:19
@mitogh mitogh closed this Mar 10, 2020
@mitogh mitogh deleted the spotfix/ET-741-promoter-listeners branch March 10, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc0ttkclark sc0ttkclark Awaiting requested review from sc0ttkclark

Assignees

@mitogh mitogh

Labels
code review Status: requires a code review.
Projects
None yet
Milestone
No milestone
6 participants
@mitogh @lucatume @sc0ttkclark @bordoni @jesseeproductions @andrasguseo