Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEC-5118] Modify notice id so it is unique per plugin #2133

Merged
merged 1 commit into from
Jul 5, 2024
Merged

[TEC-5118] Modify notice id so it is unique per plugin #2133

merged 1 commit into from
Jul 5, 2024

Conversation

codingmusician
Copy link
Contributor

@codingmusician codingmusician commented Jul 5, 2024 •
edited by jira bot
Loading

🎫 Ticket

TEC-5118

🗒️ Description

The notices weren't unique, so when several plugins were updated at once, only one notice was showing.

🎥 Artifacts

image

✔️ Checklist

  • Changelog entry in the readme.txt file.
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

@codingmusician codingmusician added the code review Status: requires a code review. label Jul 5, 2024
@codingmusician codingmusician self-assigned this Jul 5, 2024
@codingmusician codingmusician merged commit 6727c68 into bucket/plugin-consolidation Jul 5, 2024
11 of 16 checks passed
@codingmusician codingmusician deleted the tweak/TEC-5118-unique-notice-ids branch July 5, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafsuntaskin rafsuntaskin rafsuntaskin approved these changes

Assignees

@codingmusician codingmusician

Labels
code review Status: requires a code review.
Projects
None yet
Milestone
No milestone
2 participants
@codingmusician @rafsuntaskin