Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.finally and subtrees #26

Closed
paulyoung opened this issue Mar 3, 2015 · 1 comment
Closed

.finally and subtrees #26

paulyoung opened this issue Mar 3, 2015 · 1 comment

Comments

@paulyoung
Copy link
Contributor

.finally should not be called on a subtree since the subtree is part of the parent decision tree. Calling .finally on the subtree would prevent further promise to be called.

I think we should make this error out if not already.

@bergie
Copy link
Contributor

bergie commented Mar 4, 2015

@paulyoung yeah, this will error since the parent node will subscribe to the subtree via a then, and doing that after finally throws.

checkFinal: ->

@bergie bergie closed this as completed Mar 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants