Eating items in .all

[paulyoung]

No eating of items should be done in .all() promise method since they all run in parallel we could easily get in the situation where we eat the same item twice.

Similar to #26. I think we should make this error out too.

[d4tocchini]

@bergie, I thought we fixed this issue by attaching eaten content to the nodes? Subtrees will likely eat an item or a block, not being able to use such subtree in an all is a very strange limitation. Taylor is doing this now...

If this limitation is to remain, we will likely need another all composite promise that is synchronous.

[bergie]

@d4tocchini we do attach them, but only after the sub-promises resolve. Since JS is single-threaded, this would in effect makes the promises in .all run serially, not in parallel. So, in that sense it probably works.

[bergie]

Hmm... I think it actually works, but we'd need a test to prove it

[paulyoung]

I added a (failing) spec for this in 322cd06.

[paulyoung]

@cbchouinard: another docs update needed here.

[bergie]

Note: this only works as long as the tasks given to all are synchronous

[paulyoung]

@bergie: could you clarify? I'm not sure what that translates to in the API.

[bergie]

@paulyoung currently we're running every component in flowerflip synchronously, and that allows eating in all to work since one task completes before the next starts. If the tasks were async, they'd all start at the same time, and wouldn't see what the others do. Not a concern for design systems (where everything will be sync), but something to keep in mind.