Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search v2 improvements/bugs #372

Open
1 of 8 tasks
charlypoly opened this issue May 10, 2022 · 5 comments
Open
1 of 8 tasks

Search v2 improvements/bugs #372

charlypoly opened this issue May 10, 2022 · 5 comments
Assignees

Comments

@charlypoly
Copy link
Contributor

charlypoly commented May 10, 2022

@charlypoly charlypoly self-assigned this May 10, 2022
@dimaMachina
Copy link
Collaborator

when search is opened should have Esc icon instead of Cancel
image
image

@dimaMachina
Copy link
Collaborator

highlight color is missing opacity I removed it's explicitly due installation of 1 package to change opacity in 1 place

@charlypoly
Copy link
Contributor Author

charlypoly commented May 10, 2022

highlight color is missing opacity I removed it's explicitly due installation of 1 package to change opacity in 1 place

@B2o5T yes but it was crucial UX wise because right now the highlight colors look very bad, for example on the GraphQL Tools website:

image

@dimaMachina
Copy link
Collaborator

dimaMachina commented May 10, 2022

yes but it was crucial UX wise because right now the highlight colors look very bad, for example on the GraphQL Tools website:

maybe instead of setting background as accentColor we should change text color of accentColor + fontWeight: bold?

Or keep background color as accentColor but text color should have invert effect

@charlypoly
Copy link
Contributor Author

maybe instead of setting background as accentColor we should change text color of accentColor + fontWeight: bold?

I guess just text-color would do the job yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants