Skip to content
This repository has been archived by the owner on Sep 20, 2022. It is now read-only.

guild docs is incompatible with react 18 #580

Closed
n1ru4l opened this issue May 6, 2022 · 7 comments
Closed

guild docs is incompatible with react 18 #580

n1ru4l opened this issue May 6, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@n1ru4l
Copy link
Member

n1ru4l commented May 6, 2022

No description provided.

@dimaMachina
Copy link
Collaborator

with react 17 or 18?

@n1ru4l n1ru4l changed the title guild docs is incompatible with react 17 guild docs is incompatible with react 18 May 6, 2022
@n1ru4l
Copy link
Member Author

n1ru4l commented May 6, 2022

18 my bad, I updated the title :D

@vicary
Copy link

vicary commented Aug 3, 2022

@B2o5T I am working on gqty-dev/gqty#772 and found that, despite this issue claims a finished migration, the peer dependency of @theguild/components@^1.11.2 which should be upgraded to at least 2.0.0

@dimaMachina
Copy link
Collaborator

@vicary @theguild/components@2.0.0 requires react 18

@vicary
Copy link

vicary commented Aug 3, 2022

@B2o5T Oh I thought this issue is for React 18, I must have missed something.

I am upgrading to React 18 in gqty-dev/gqty#772. When I upgrade @guild-doc/client@^3.1.0 its peer dependency of @theguild/components@^1.11.2 throws about React 18 being too new.

Is there a version of @guild-doc/client being compatible with React 18?

@dimaMachina
Copy link
Collaborator

We no longer uses @guild-doc/client
see the example of website https://github.com/the-guild-org/the-guild-docs/tree/main/website

@vicary
Copy link

vicary commented Aug 3, 2022

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants