Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item sellFor field CurrencyItems throwing errors #54

Closed
MoonTM-GIT opened this issue Jun 18, 2022 · 4 comments
Closed

Item sellFor field CurrencyItems throwing errors #54

MoonTM-GIT opened this issue Jun 18, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@MoonTM-GIT
Copy link

MoonTM-GIT commented Jun 18, 2022

Whenever I try to get information about the currencyItem of an ItemPrice, where the Vendor is not the flea, I got from the sellFor field of an Item I get this error: No item found with id undefined. It works fine for ItemPrices I got from the buyFor field.

That explanation is quite bad, so I attached a little visualization from my debugger, you can easily test that on the playground as well though. Excuse the bad writing, had to do that with my mouse.

Wherever currencyItem is null the error occurred, this is the case for elements 0-3 of the sellFor list

image

@GrantBirki GrantBirki added the bug Something isn't working label Jun 18, 2022
@austinhodak
Copy link
Member

@Razzmatazzz

@Razzmatazzz
Copy link
Member

This should be fixed now.

@GrantBirki
Copy link
Member

GrantBirki commented Jun 25, 2022

@Razzmatazzz Which PR closed this issue?

fun fact, you can do this in a PR and it will automatically close the issue when the PR is merged:

resolves: <pr url>

Check out this goodness: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@Razzmatazzz
Copy link
Member

It was resolved by: #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants