Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

German Translations and clearer barter page description in English #574

Merged
merged 9 commits into from
Jul 10, 2023
Merged

German Translations and clearer barter page description in English #574

merged 9 commits into from
Jul 10, 2023

Conversation

ogruendel
Copy link
Contributor

German Translations and clearer barter page description in English

Description 🗒️

Translated all remaining strings in translation.json from English into German and made barter page description more clear

Expand for Help

By submitting this pull request, you agree to our code of conduct

@ogruendel ogruendel requested a review from a team as a code owner July 10, 2023 11:39
@Shebuka
Copy link
Contributor

Shebuka commented Jul 10, 2023

Great first PR and definitely a better barters page description ;)

To make the translation complete you need to also copy the 3 new page-specific translation files we added since the first pass of DE translation was made, you can find them in https://github.com/the-hideout/tarkov-dev/tree/main/src/translations/en folder and just copy them in the de folder and translate.

@ogruendel
Copy link
Contributor Author

I've added the 3 missing files with my latest commits and cleared fixed up some errors and outdated information along the way! I hope this will help some people and make information about Tarkov more accessible

Shebuka
Shebuka requested changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@Shebuka Shebuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes will fix html tag markers (don't know how they got broken in the first place... will update later for other languages too)

src/translations/en/translation.json Outdated Show resolved Hide resolved
src/translations/de/translation.json Outdated Show resolved Hide resolved
ogruendel
ogruendel commented Jul 10, 2023
View reviewed changes
Copy link
Contributor Author

@ogruendel ogruendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't notice the broken HTML Tags there, but good they were spotted and fixed

@Shebuka
Copy link
Contributor

Shebuka commented Jul 10, 2023

.deploy

@github-actions
Copy link
Contributor

Deployment Triggered 🚀

Shebuka, started a branch deployment to production

You can watch the progress here 🔗

Branch: 3974f04eb8a8977af5c7afd8e9179fb1ee9b9720

@github-actions github-actions bot temporarily deployed to production July 10, 2023 16:07 Inactive
@github-actions
Copy link
Contributor

Deployment Results ✅

Shebuka successfully deployed branch 3974f04eb8a8977af5c7afd8e9179fb1ee9b9720 to production

Environment URL: tarkov.dev

@Shebuka Shebuka merged commit 5c81bd5 into the-hideout:main Jul 10, 2023
2 checks passed
@ogruendel ogruendel mentioned this pull request Jul 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shebuka Shebuka Shebuka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ogruendel @Shebuka