Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update japanese translation #833

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Update japanese translation #833

merged 3 commits into from
Jan 30, 2024

Conversation

nagoyatokyo
Copy link
Contributor

Update Japanese Translation

Description 🗒️

This pull request completes the Japanese translation progress to 100%.

Examples 📸

Related Issues 🔗

#175

Expand for Help

By submitting this pull request, you agree to our code of conduct

@nagoyatokyo nagoyatokyo requested a review from a team as a code owner January 27, 2024 17:37
@GrantBirki GrantBirki added the language Changes related to wording on the site or translations label Jan 28, 2024
@GrantBirki
Copy link
Member

.deploy to development

@github-actions GitHub Actions
Copy link
Contributor

Deployment Triggered 🚀

GrantBirki, started a branch deployment to development

You can watch the progress here 🔗

Branch: 57b0b77bb6bd3d32f4a4685cb11799e432f04740

@github-actions GitHub Actions
Copy link
Contributor

Deployment Results ✅

GrantBirki successfully deployed branch 57b0b77bb6bd3d32f4a4685cb11799e432f04740 to development

Show Results

https://3b9fd969.tarkov-dev.pages.dev

@GrantBirki
Copy link
Member

@root309 checkout the development deployment and let us know if everything looks okay! 🇯🇵

@nagoyatokyo
Copy link
Contributor Author

nagoyatokyo commented Jan 28, 2024 •
edited
Loading

@GrantBirki I've checked the development deployment of the tarkov-dev, and I can confirm that everything looks okay with the changes I made. There are no issues to report!

Shebuka
Shebuka requested changes Jan 28, 2024
View reviewed changes
src/translations/ja/translation.json Outdated Show resolved Hide resolved
@nagoyatokyo
Copy link
Contributor Author

@Shebuka I executed a script to fix the order of keys in each JSON file!

Shebuka
Shebuka approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@Shebuka Shebuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@Shebuka
Copy link
Contributor

Shebuka commented Jan 29, 2024

.deploy

@github-actions GitHub Actions
Copy link
Contributor

Deployment Triggered 🚀

Shebuka, started a branch deployment to production

You can watch the progress here 🔗

Branch: e5454ff76c247b3d52573b5055dac6886e71394f

@github-actions GitHub Actions
Copy link
Contributor

Deployment Results ✅

Shebuka successfully deployed branch e5454ff76c247b3d52573b5055dac6886e71394f to production

Environment URL: tarkov.dev

@nagoyatokyo
Copy link
Contributor Author

@Shebuka
I noticed that the translation.json file does not contain the newly added translation keys.

Since the translation.json file does not seem to contain some of the new translation keys I have added, please refrain from merging pull requests at this time. I will work on resolving this issue and update the file accordingly.

@nagoyatokyo
Copy link
Contributor Author

@Shebuka
I revised the script for fixing the key order and ran it again. It seems that the latest commit has preserved the original key order of the translation.json file, and all the changes I made in the translation have been successfully added.

@github-actions github-actions bot mentioned this pull request Jan 29, 2024
Merged
@GrantBirki
Copy link
Member

.deploy

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Cannot claim deployment lock

Sorry GrantBirki, the production environment deployment lock is currently claimed by Shebuka

Lock Details 🔒

  • Environment: production
  • Branch: e5454ff76c247b3d52573b5055dac6886e71394f
  • Created At: 2024-01-29T15:35:27.011Z
  • Created By: Shebuka
  • Sticky: true
  • Global: false
  • Comment Link: click here
  • Lock Link: click here

The current lock has been active for 0d:6h:38m:34s

If you need to release the lock, please comment .unlock production

@GrantBirki
Copy link
Member

.unlock production

@github-actions GitHub Actions
Copy link
Contributor

🔓 Deployment Lock Removed

The production deployment lock has been successfully removed

@GrantBirki
Copy link
Member

.deploy production

@github-actions GitHub Actions
Copy link
Contributor

Deployment Triggered 🚀

GrantBirki, started a branch deployment to production

You can watch the progress here 🔗

Branch: 78669babbf3a5f53b8980c2c78ae398069726c80

@github-actions GitHub Actions
Copy link
Contributor

Deployment Results ✅

GrantBirki successfully deployed branch 78669babbf3a5f53b8980c2c78ae398069726c80 to production

Environment URL: tarkov.dev

@GrantBirki
Copy link
Member

.unlock production

@github-actions GitHub Actions
Copy link
Contributor

🔓 Deployment Lock Removed

The production deployment lock has been successfully removed

@Shebuka Shebuka merged commit 32d21ca into the-hideout:main Jan 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shebuka Shebuka Shebuka approved these changes

@GrantBirki GrantBirki GrantBirki approved these changes

Assignees
No one assigned
Labels
language Changes related to wording on the site or translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nagoyatokyo @GrantBirki @Shebuka