[Enhancement] Footer Changes #915
Conversation
|
.deploy to development |
|
|
.unlock development |
🔓 Deployment Lock RemovedThe |
There was a problem hiding this comment.
Discord: Simplified to just use a shields.io img/button that shows users online count (Still requires widget to be enabled on server)
X/Twitter: Also changed to use shields.io img/button to view X/Twitter
These are some significant changes and I would like to keep them as they were for now, revert please.
Removed the " : " in the "Made with love by"
The use of a colon here is justified as it introduces a list of contributors, so please revert it back too :)
Reverted now back to original formatting to comply with your request 👍 |
I just looked at the changes and the discord iframe is still missing |
|
I'm confused... the reason for this PR mainly was to fix the issue originally opened #914 unless maybe you know a way to fix the CORS error without removing the iFrame / making sure no one has a default profile picture / avatar and finding a way to fix the discord widget from extending off the page, I am all for it but currently there is no known resolutions hence why I said in the OP above:
|
|
There is also already multiple references to the discord I attempted to use the shields.io as a replacement for the "online users" as that is nice to see but you asked to revert / remove that change. |
You replaced the iframe with the image in the PR, but using iframe is the current and only official way to embed a discord widget in the site. Also, it does work and everything is loading fine so I want to keep using it. |
As of 15 October 2023 they are still actively supporting the widget: discord/discord-api-docs#6447 Its expanding and changing footer height with animation is not ideal, but that can be solved with layout updates, not by removing the widget. |
I can give a list of reasons why I don't think the discord widget is good
If you insist on keeping the discord widget I would almost be more excited to create a customized version of it than using the default widget layout with something like the one below
Just because something "works and everything is loading fine" does not mean its the best option. If you want to keep everything as is that's ok just edit my PR or close it I'll work on a custom widget if it is a must have when I have time. |
|
I agree the current Discord widget has some issues (especially on mobile). It might make sense to just have a discord image and join link. But I could be overlooking some of the usefulness of the current widget. |
|
My 5 cents: While the current discord widget is the official one, the two negatives @lyricalcasanova outlined above heavily outway that. Id be onboard with either disabling the folding and make the click action redirect to our join link instead of discords website or just using shields.io at that point. Im using shields.io for many of my repos as well and only ever had good experiences with it so far. 
|
DysektAI
changed the title
It's not that "Just because something "works and everything is loading fine" does not mean its the best option." My first glance comparison was: shields.io:
Cons:
Discord widget:
when expanded:
Cons:
No call to action in your shields.io implementation is a major stopper for me (it's also why I didn't like shields.io for X). As for other pros missing, I can deal with it if for others it's ok. |
Previous Replies> > > > I'm confused... the reason for this PR mainly was to fix the issue originally opened #914 unless maybe you know a way to fix the CORS error without removing the iFrame / making sure no one has a default profile picture / avatar and finding a way to fix the discord widget from extending off the page, I am all for it but currently there is no known resolutions hence why I said in the OP above: (I did search for others who had this issue but it seems like the widget for discord was made in 2016 and the most recent posts I found were in 2022 with no answers that are similar to this) > > > > > Not sure why the default profile avatars for discord are throwing CORS errors so I assume it's best to just remove it / replace it (Also when hovered it extended past the bottom of the screen) > > > > > > > > > As of 15 October 2023 they are still actively supporting the widget: [discord/discord-api-docs#6447](https://github.com/discord/discord-api-docs/issues/6447) I sincerely do not understand why you think the widget is bad? > > > Its expanding and changing footer height with animation is not ideal, but that can be solved with layout updates, not by removing the widget. > > > > > > I can give a list of reasons why I don't think the discord widget is good > > > > 1. It expands and causes weird issues where users have to scroll awkwardly through a list of users to even see or access the "join server" button and expands the footer to over half of the monitor on desktop. > > 2. The discord icon does not link to the server, it links directly to discords website which users will most likely click on if they don't scroll. > > 3. Do users need to see the voice channels and users in the discord on the page before clicking join server? > > > > If you insist on keeping the discord widget I would almost be more excited to create a customized version of it than using the default widget layout with something like the one below > > Just because something "works and everything is loading fine" does not mean its the best option. > > If you want to keep everything as is that's ok just edit my PR or close it I'll work on a custom widget if it is a must have when I have time.
I find the Discord 300 Online more of a call to action than a generic discord widget, that users get lost just trying to find the "join server" button because it overflows off the screen then users have to scroll down users list to the bottom battling the on hover transition.
Styling in Shields is subjective, I simply used the color pallet that I thought looks clean
Do you really need to see the online users list in the discord before you join?
User count - Online Users is also in Shields.io as one of your pros above
See above (Unless you mean the widget itself)
See above
See above
Same argument as the users list I have never worried about how many users are in the voice channels especially for a server centered around developing and tarkov news/updates
With all respect, @Shebuka it seems we can't come to a solid agreement. You do have the option to contribute your own code / changes that you would like to see if you feel strongly about anything. From the consensus so far, it seems like you may be the only one not okay with removing this generic widget I'm tired of debating over 32 changes, at this point unless there is truly a valid argument to make I will leave it up to the maintainers to decide what they want to do with this PR either Close, Edit, or Merge. |
|
Oh man, just wow... In the last comment, I've explained to you the reason behind my INITIAL request to rollback... I thought it was clear with using the past tense...
Where is a call to action here? (your screen) YOU said that
and Im saying ok if it has a call to action and is stylized like DIscord as YOU showed in the screenshot.
Where does even
come from??? |
|
Seems like this discussion is causing some frustration for multiple people. Let's not lose sight of the fact that we all have the common goal of making the website as good as it can be to be as useful to the community as possible. Yes, we will sometimes have differences of opinion on what makes the website the best, but we should be able to discuss those differences respectfully and reach a consensus on the best way to move forward. My two cents is that the current discord widget causes some annoying behavior (particularly on mobile). The shields.io solution seems like a good substitute as it provides a recognizable join link plus the current user count. While it does lack the ability to see who is online, voice channels, etc., I don't view those features as being vital (especially when crammed into the website footer). |
The call to action is the shields.io with a count of the online users, this causes curiosity from the users to wonder what is in the discord which makes them want to click it. The requests to rollback was done as you requested with the exception of the discord widget as you did not mention the widget in your original request here:
These are some significant changes and I would like to keep them as they were for now, revert please.
The use of a colon here is justified as it introduces a list of contributors, so please revert it back too :) Maybe there was some misunderstanding from the above comment but I see no reference in this comment anywhere specifying the discord widget not being removed simply just asking "revert please." with my change points referenced about the shields.io for x/twitter and discord this could not be further from clearly communicating in the future please provide more details, examples, or code so it's more clear. I did as you requested which is the current state of this PR, then you asked where the widget is? |
|
Also please enlighten me maybe my understanding of a "Call To Action" is wrong I thought a call to action was something that provokes people to click or find interest in doing something like a button / link? Is the button that says "Discord 283 Online" with a link to the Discord Server not a Call To Action? Maybe it has to be a big bright button that follows none of the websites color scheme and jumps off the page or says "CLICK TO JOIN THE DISCORD" but I'm not sure because "Call To Action" in website design is defined as: |
|
Maybe there was some misunderstanding, let's reset the conversation. On this point:
Briefly:
I hope this helps understand the whole conversation flow and clears the confusion. About what is a "Call To Action": As you quoted it is any form of 'visual' message (a text, a button, an arrow) that invites the user to do something. An image with "Discord 283 Online" is a statement of fact, like "build: passing" (see below). By look and feel it has all the functions of an image, no user will think it's a button without hovering the mouse over it (can't be done on mobile), and even after that they don't know what it does (URL in the status bar is not telling much), so it's clearly not a "Call To Action". So, like what you showed is a perfect component with a clear call to action: p.s. I never saw use of shileds outside of github and other related coding websites, so to general Tarkov website users it's just an image, as it is the |
|
Note: Accidentally merged the wrong branch (#911) force pushed to revert the merge, I would normally just add a revert commit but this was necessary @Shebuka and @Razzmatazzz
I have reverted the change and included the Discord Widget until there's an acceptable replacement for it as Shebuka is right it's best to have both options until then. |
|
.deploy to development |
Deployment Triggered 🚀Razzmatazzz, started a branch deployment to development You can watch the progress here 🔗
|
Deployment Results ✅Razzmatazzz successfully deployed branch Show Results |
|
.deploy |
Deployment Triggered 🚀Shebuka, started a branch deployment to production You can watch the progress here 🔗
|
Deployment Results ✅Shebuka successfully deployed branch
|
Edited the footer layout
Description 🗒️
Changes
-Removed "Escape from Tarkov Dev tracker" seems inactive and rarely necessary unless this is required I don't see a use for it
-Removed the commented out link to "API Users" page
+Added "Tarkov Monitor" as a resource linked to the github since its not listed anywhere
~Re-ordered the Resources and External Sources to be more stylish
(Reverted)
Discord: Simplified to just use a shields.io img/button that shows users online count (Still requires widget to be enabled on server)X/Twitter: Also changed to use shields.io img/button to view X/TwitterRemoved the " : " in the "Made with love by"Examples 📸
Before
After
Related Issues 🔗
#914 (Does not fix the issue but its planned)