Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tag_id property to base class #24

Closed
adamlm opened this issue Jun 29, 2023 · 1 comment · Fixed by #25
Closed

Move tag_id property to base class #24

adamlm opened this issue Jun 29, 2023 · 1 comment · Fixed by #25
Assignees
@adamlm
Labels
enhancement New feature or request

Comments

@adamlm
Copy link
Collaborator

adamlm commented Jun 29, 2023

Right now, only the ActiveTag has a tag_id property. However, passive and active tags both have identifiers. Moving this function to the base class would allow PassiveTag instances to get their identifiers, even if they are unused.
@adamlm adamlm added the enhancement New feature or request label Jun 29, 2023
@adamlm adamlm self-assigned this Jun 29, 2023
adamlm added a commit that referenced this issue Jun 29, 2023
@adamlm
#24 Move tag_id property to UartDwm1001 class
d7d0989 
This property can be used by both PassiveTags and ActiveTags.
adamlm added a commit that referenced this issue Jun 29, 2023
@adamlm
#24 Bump project version
f83dae3 
Version is now 0.5.0
@adamlm adamlm mentioned this issue Jun 29, 2023
Merged
@adamlm
Copy link
Collaborator Author

adamlm commented Jun 29, 2023

Closed by #25

@adamlm adamlm closed this as completed Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamlm adamlm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move tag_id property to UartDwm1001 base class the-hive-lab/pydwm1001
1 participant
@adamlm