Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode the input before building XML commands. #57

Open
wants to merge 1 commit into
base: pathogen-bundle
Choose a base branch
from

Conversation

xunam
Copy link

@xunam xunam commented Apr 10, 2017

As spotted in issue #53, Coquille chokes on non-ASCII input because of encoding problems and Python throwing UnicodeDecodeError exceptions. This is a simple fix for the issue, it consists in

  • decoding the text from Vim's buffer when creating an XML command (the data we get from Vim is a byte string as a Python str, we turn it into a unicode following the buffer's encoding)
  • accepting the unicode type in command encoding.

My first tests work fine but it surely deserves to be checked.

@dadoomer
Copy link

dadoomer commented May 7, 2017

Indeed, this seems to solve the problem for me.

@dustnnbones
Copy link

@xunam do you have an example of how you fixed the issue?

@xunam
Copy link
Author

xunam commented Oct 23, 2023

Hi, I'm not sure what you mean by "example" here, but if I remember well, I fixed the issue by patching the code as in the present PR, which has no conflict according to Github. But it seems that this repository has been unmaintained for 6 years now.

Actually, I ended up writing my own Coq plugin from scratch to support later versions of Coq instead of forking coquille, because the way Coq interacts has changed completely : https://framagit.org/manu/coq-au-vim
It has a few open issues but it works reasonably well for me. Feel free to try it !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants