Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Automatically use lto in release #8

Closed
Milo123459 opened this issue Aug 27, 2021 · 4 comments
Closed

Feature: Automatically use lto in release #8

Milo123459 opened this issue Aug 27, 2021 · 4 comments
Labels
wontfix This will not be worked on

Comments

@Milo123459
Copy link

Just automatically add:

[profile.release]
lto = "fat"
@Byron Byron added the wontfix This will not be worked on label Aug 28, 2021
@Byron
Copy link
Collaborator

Byron commented Aug 28, 2021

No argument was provided to explain why this would be valuable.
When thinking about this, I can only come up with an argument against such feature: cargo diet is about keeping crates packages small, it isn't concerned with binary size.

Please feel free to provide arguments on the closed issue though, maybe I am not seeing something.

@Byron Byron closed this as completed Aug 28, 2021
@Milo123459
Copy link
Author

Well, if you can make the binary smaller, isn't the crate smaller? Or am I missing something?

@Byron
Copy link
Collaborator

Byron commented Aug 28, 2021

Well, if you can make the binary smaller, isn't the crate smaller?

The crate is a package containing source code to build the binary or other artifacts, not every crate produced binaries. cargo diet only means to slim down the amount of source code shipped in these crates and leaves configuring artifacts entirely to the crate owners. Changing build settings really isn't anything where one size fits all.

@Milo123459
Copy link
Author

I see, I think I must've misunderstood a few things along the line.. Mb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants