Basic client framework, slight server threading optimization #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a window styled after the PaperClip window, with page count and url. TODO includes: Separate thread for the window (The window should never be the same task as the guts) and unit tests to confirm that update of the page count works as intended.
Merge remote-tracking branch 'getuser/master' into betterusers No integration of code just yet.
Original mechanism was processor intensive, used sleep() Used threading.join() with no timeout to simplify. Now master thread will simply block until all threads are completed.
Todo includes actually getting a server link, and using that to define what our queue will be. That is for a future time. Right now we have 1 master thread that starts a gui thread which in turn runs two inter-dependant sub-threads. The death of either sub-thread will trigger the death of the other. Upon those sub-threads dying, the controller also dies. The master is left to run the networking side of things.
|
Will not merge commit f332019, sleep is in there for platform legacy reasons. |
|
For documentation reasons, see this StackOverflow question |
|
Regarding stackless python Thread.join() acting differently, it is not so according to the docs. That said, change reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client side:
Todo includes actually getting link to a server, and using that to
define what our queue will be. That is for a future time.
Right now we have 1 master thread that starts a gui thread
which in turn runs two inter-dependent sub-threads.
The death of either sub-thread will trigger the death of the other.
Upon those sub-threads dying, the controller also dies.
The master is left to run the networking side of things. (future)
Added the suggested gist regarding usernames to my code.
Server side:
Original mechanism was processor intensive, used sleep()
Used threading.join() with no timeout to simplify.
Now master thread will simply block until all threads are completed.