Gh 184 introduce wikibase service clause #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is still a bug, the query optimizer is reordering the queries. The SERVICE clause should be evaluated last in order to have the bindingSet filled. This is currently not always the case |
ate47
requested changes
Nov 6, 2022
...qs-backend/src/main/java/com/the_qa_company/qendpoint/federation/ServiceClauseOptimizer.java
Outdated
Show resolved
Hide resolved
hdt-qs-backend/src/main/java/com/the_qa_company/qendpoint/federation/WikibaseLabelService.java
Outdated
Show resolved
Hide resolved
hdt-qs-backend/src/main/java/com/the_qa_company/qendpoint/federation/WikibaseLabelService.java
Outdated
Show resolved
Hide resolved
hdt-qs-backend/src/main/java/com/the_qa_company/qendpoint/federation/WikibaseLabelService.java
Outdated
Show resolved
Hide resolved
ate47
reviewed
Nov 30, 2022
...ckend/src/main/java/com/the_qa_company/qendpoint/federation/SPARQLServiceResolverCustom.java
Outdated
Show resolved
Hide resolved
hdt-qs-backend/src/main/java/com/the_qa_company/qendpoint/federation/WikibaseLabelService.java
Outdated
Show resolved
Hide resolved
|
wow this interface is so complicated! I made all the changes already this morning directly after we discussed .... you did not get any notification right? @ate47 Is there something pending? |
ate47
approved these changes
Dec 1, 2022
|
Fine for me, can you squash your commits before the merge? |
Apply formatter Windows disclaimer Preparing for release 1.7.1 fix docker CI fix ci #173 GH-167 sync writer (#176) GH-167 sync writer GH-181 Remove shutdown and add copy test (#182) First complete version of Wikibase query service for languages Running formatter Rename class to more meaningfull name Rename class to more meaningfull name Don't return null but throw error at the end of the iterator
…thub.com/the-qa-company/qEndpoint into GH-184-introduce-Wikibase-service-clause
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of this pull request:
This is a first draft of the Wikibase language SERVICE functionality described here:
https://en.wikibooks.org/wiki/SPARQL/SERVICE_-_Label
For now only the Automatic Label SERVICE is implemented. Also some more testing is needed
Please check all the lines before posting the pull request:
mvn formatter:formaton the backend,npm run formaton the frontend) before posting my pull request,mvn formatter:validateto validate the formatting on the backend,npm run validateon the frontend