Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix --continue_flag #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix --continue_flag #8

wants to merge 1 commit into from

Conversation

cgahr
Copy link
Collaborator

@cgahr cgahr commented Mar 28, 2024

the --continue_file flag does not work, this PR fixes it.

@cgahr cgahr requested a review from the-rccg March 28, 2024 17:51
@the-rccg
Copy link
Owner

the-rccg commented Apr 9, 2024 •
edited
Loading

The flag was part of a bigger feature bump that was still in the works. The full code is now pushed with release v1.0.3 and v1.0.4
Two features from this PR are not included as of yet:

  • continue from a different file than to save to (maybe adding a load_file flag would be more intuitive for this feature?)
  • sanity check on resolution (a full sanity check function might be appropriate instead of simple dx?)
    Please let me know if you have any thoughts on these.

The new version now allows for saving high-res snapshots of the last state in full double precision for continuing interrupted runs or downsampled runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-rccg the-rccg Awaiting requested review from the-rccg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cgahr @the-rccg