Fail if a given protocol version *isn't* supported.

(Broken when RPCAP_VERSION_IS_SUPPORTED() was introduced.)
the-tcpdump-group · Nov 28, 2017 · 2972769 · 2972769
1 parent cb0a452
commit 2972769
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pcap-rpcap.c b/pcap-rpcap.c
@@ -1976,7 +1976,7 @@ static int rpcap_sendauth(SOCKET sock, uint8 *ver, struct pcap_rmtauth *auth, ch
 			 *
 			 * Do we also support it?
 			 */
-			if (RPCAP_VERSION_IS_SUPPORTED(header.ver))
+			if (!RPCAP_VERSION_IS_SUPPORTED(header.ver))
 			{
 				/*
 				 * No, so there's no version we both support.

diff --git a/rpcapd/daemon.c b/rpcapd/daemon.c
@@ -237,7 +237,7 @@ void *daemon_serviceloop(void *ptr)
 		//
 		// Did the client specify a version we can handle?
 		//
-		if (RPCAP_VERSION_IS_SUPPORTED(header.ver))
+		if (!RPCAP_VERSION_IS_SUPPORTED(header.ver))
 		{
 			//
 			// Tell them it's not a valid protocol version.