Skip to content

Commit

Permalink
Fail if a given protocol version *isn't* supported.
Browse files Browse the repository at this point in the history
(Broken when RPCAP_VERSION_IS_SUPPORTED() was introduced.)
  • Loading branch information
guyharris committed Nov 28, 2017
1 parent cb0a452 commit 2972769
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pcap-rpcap.c
Original file line number Diff line number Diff line change
Expand Up @@ -1976,7 +1976,7 @@ static int rpcap_sendauth(SOCKET sock, uint8 *ver, struct pcap_rmtauth *auth, ch
*
* Do we also support it?
*/
if (RPCAP_VERSION_IS_SUPPORTED(header.ver))
if (!RPCAP_VERSION_IS_SUPPORTED(header.ver))
{
/*
* No, so there's no version we both support.
Expand Down
2 changes: 1 addition & 1 deletion rpcapd/daemon.c
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ void *daemon_serviceloop(void *ptr)
//
// Did the client specify a version we can handle?
//
if (RPCAP_VERSION_IS_SUPPORTED(header.ver))
if (!RPCAP_VERSION_IS_SUPPORTED(header.ver))
{
//
// Tell them it's not a valid protocol version.
Expand Down

0 comments on commit 2972769

Please sign in to comment.