Add in support for network namespaces #676

acmay · 2018-02-22T07:07:32Z

Here is a cut at doing the namespace changes in libpcap for issue #587

I am still not sure on the libpcap details and I am tempted to create a new function pointer to set/unset the namespace (or not) from the pcap.c file so I don't have to catch every return location in the -linux files.

I also left a few comment questions.

mcr · 2019-04-26T14:05:24Z

please rebase.

acmay · 2019-04-26T15:04:22Z

Still working on it. Got it building and starting to work just now.

Any ideas on the handle.opt.device vs handlep->device?
I did a search replace on handle.opt.device to HDEV(handle) but still looking if there is a different approach.

fxlb · 2019-05-01T07:35:04Z

@acmay "wants to merge 774 commits" ???
Have you rebased your branch on the-tcpdump-group:master ?

acmay · 2019-05-01T16:09:53Z

@acmay "wants to merge 774 commits" ???
Have you rebased your branch on the-tcpdump-group:master ?

Just struggling with getting git to do what I want. So no I don't want to merge all those commits just one. I can't tell if I can fix it in git easily enough or if I should just start over with doing some file copies.

Add in cmake checking for namespace support and pcap_get_caps() Fixup pcap_get_caps() function to let an application find out the caps that need to be kept to capture packets. Add in c-define for SYS_CAPABILITY Add in another ifdef check on sys capabilities Yet another spot for an ifdef namespaces Always pass in devprefix instead Remove un-needed var

acmay · 2019-05-02T00:01:36Z

Hopefully closer to ready now. Some whitespace fixes to make but I would like to get some comments before taking another pass and getting things down to 1 commit.

fxlb · 2019-08-04T12:44:13Z

This PR should be rebased on master for a better history.

omerb4 · 2020-01-15T12:33:10Z

Is this PR going to be merged soon?

mcr · 2020-01-15T15:43:11Z

omerb4 <notifications@github.com> wrote: Is this PR going to be merged soon? Yes.

fxlb · 2020-01-15T15:49:33Z

Github message: "This branch has conflicts that must be resolved".
This PR should be rebased on the-tcpdump-group:master for a better history and to fix conflicts.

omerb4 · 2020-01-15T15:56:53Z

Will this fix allow me to use it for docker namespace?
Cause the default namespace path is: /var/run/netns while in docker is: /var/run/docker/netns

mcr · 2020-01-16T23:12:18Z

Could you symlink /var/run/netns to /var/run/docker/netns? Or mount --bind it? Do you think that libpcap should look in both places?

acmay · 2020-01-17T16:57:14Z

I think I can spend some time rebasing and looking at things soon here.

Will this fix allow me to use it for docker namespace?
Cause the default namespace path is: /var/run/netns while in docker is: /var/run/docker/netns

I haven't used docker much myself to test there.
I would expect things to run best outside of docker. I would think inside of docker it be yet another possible level of namespaces.
Can you do a "strace ip netns ls" and see how it does it? And if you create another namespace inside docker does it appear in the to host OS layer?
I can try to check the iproute2 source to see if there are any tricks there.

acmay · 2020-01-17T17:13:32Z

iproute2 just looks in one dir.
https://github.com/shemminger/iproute2/blob/master/lib/namespace.c#L119

It is only a compile time option to change it and I am not sure what each distro does to build it. But we could do a build time option to at least match iproute2.
iproute2/iproute2@e2f5cec

omerb4 · 2020-01-18T16:17:28Z

Build time option like in iproute2 sounds good to me

omerb4 · 2020-03-01T08:07:17Z

Any news here?

guyharris · 2020-05-12T04:15:42Z

Solaris's zones (see, for example, this Sun paper and this article) might fit into a similar framework.

So, for the "enumerate devices" API, would it make more sense to

have it enumerate interfaces in all namespaces if running in the root namespace/global zone and enumerate devices in the current namespace in other namespaces/zones

or

take a namespace/zone name as an argument and, if possible, enumerate interfaces in that zone, with NULL meaning "current namespace/zone" - and have another API to list namespaces/zones, for the benefit of GUI sniffer applications? (Another API could return the appropriate name for what's being enumerated there - "namespace" or "zone".)

For zones, we already support {zone}/{interface} in Solaris for the "create" API, so presumably something similar would be used for Linux (perhaps ":" should be replaced by "/", for consistency).

(See this blog post, too.)

omeranson · 2022-03-30T06:19:02Z

CMakeLists.txt

+check_include_file(sys/capability.h HAVE_SYS_CAPABILITY_H)
+if(HAVE_SYS_CAPABILITY_H)
+  add_definitions(-DHAVE_SYS_CAPABILITY=1)
+check_c_source_compiles(


I think you can HAVE_LINUX_NETWORK_NAMESPACE without HAVE_SYS_CAPABILITY_H, no?

omeranson · 2022-03-30T06:19:06Z

CMakeLists.txt

@@ -303,6 +303,38 @@ include(CheckTypeSize)
 check_include_file(inttypes.h HAVE_INTTYPES_H)
 check_include_file(stdint.h HAVE_STDINT_H)
 check_include_file(unistd.h HAVE_UNISTD_H)
+check_include_file(sys/capability.h HAVE_SYS_CAPABILITY_H)
+if(HAVE_SYS_CAPABILITY_H)
+  add_definitions(-DHAVE_SYS_CAPABILITY=1)


Shouldn't this be true only if HAVE_SYS_CAPABILITY (set below on lines 326-336 is true?

tr33oph · 2023-04-06T07:41:36Z

Any news here?

irozzo-1A · 2023-05-24T08:49:27Z

@acmay I'm interested in this feature, is there the will to carry through? I don't know the code base at the moment, but I could try to help if needed.

cc @omeranson

acmay · 2023-05-24T16:03:05Z

I just haven’t found the time to do it myself so any help would be great. I also didn’t know the code base going into it and the auto builders are helpful to do the different build variants.

…

On Wed, May 24, 2023, at 1:49 AM, Iacopo Rozzo wrote: @acmay <https://github.com/acmay> I'm interested in this feature, is there the will to carry through? I don't know the code base at the moment, but I could try to help if needed. cc @omeranson <https://github.com/omeranson> — Reply to this email directly, view it on GitHub <#676 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANUHBQAHCI55USS4SXC4TLXHXDSHANCNFSM4ER3KSSQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

irozzo-1A · 2023-05-25T06:47:47Z

I just haven’t found the time to do it myself so any help would be great. I also didn’t know the code base going into it and the auto builders are helpful to do the different build variants.
…
On Wed, May 24, 2023, at 1:49 AM, Iacopo Rozzo wrote: @acmay https://github.com/acmay I'm interested in this feature, is there the will to carry through? I don't know the code base at the moment, but I could try to help if needed. cc @omeranson https://github.com/omeranson — Reply to this email directly, view it on GitHub <#676 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANUHBQAHCI55USS4SXC4TLXHXDSHANCNFSM4ER3KSSQ. You are receiving this because you were mentioned.Message ID: @.***>

Thanks @acmay, I will start familiarizing myself with the codebase and then I could try to rebase your PR.
Was there anything missing apart from the few unhandled comments?

acmay mentioned this pull request Oct 29, 2018

Linux network namespace support? #587

Open

mcr added this to the release-after-next milestone Apr 26, 2019

mcr added improvement linux labels Apr 26, 2019

acmay added 2 commits May 1, 2019 13:43

squash! Add in support for network namespaces

8ff5de9

acmay force-pushed the master branch from 0fca433 to 8ff5de9 Compare May 1, 2019 22:57

Remove unused variable

4f39cbc

acmay added 2 commits August 3, 2019 22:52

Cleanup whitespace.

d7faf37

Merge https://github.com/the-tcpdump-group/libpcap

a241297

mcr self-assigned this Jan 15, 2020

mcr modified the milestones: release-after-next, next-release Mar 2, 2020

omeranson reviewed Mar 30, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add in support for network namespaces #676

Add in support for network namespaces #676

acmay commented Feb 22, 2018

mcr commented Apr 26, 2019

acmay commented Apr 26, 2019

fxlb commented May 1, 2019 •

edited

acmay commented May 1, 2019

acmay commented May 2, 2019

fxlb commented Aug 4, 2019

omerb4 commented Jan 15, 2020

mcr commented Jan 15, 2020 via email

fxlb commented Jan 15, 2020

omerb4 commented Jan 15, 2020

mcr commented Jan 16, 2020 via email

acmay commented Jan 17, 2020

acmay commented Jan 17, 2020

omerb4 commented Jan 18, 2020

omerb4 commented Mar 1, 2020

guyharris commented May 12, 2020

omeranson Mar 30, 2022

omeranson Mar 30, 2022

tr33oph commented Apr 6, 2023

irozzo-1A commented May 24, 2023

acmay commented May 24, 2023 via email

irozzo-1A commented May 25, 2023

Add in support for network namespaces #676

Are you sure you want to change the base?

Add in support for network namespaces #676

Conversation

acmay commented Feb 22, 2018

mcr commented Apr 26, 2019

acmay commented Apr 26, 2019

fxlb commented May 1, 2019 • edited

acmay commented May 1, 2019

acmay commented May 2, 2019

fxlb commented Aug 4, 2019

omerb4 commented Jan 15, 2020

mcr commented Jan 15, 2020 via email

fxlb commented Jan 15, 2020

omerb4 commented Jan 15, 2020

mcr commented Jan 16, 2020 via email

acmay commented Jan 17, 2020

acmay commented Jan 17, 2020

omerb4 commented Jan 18, 2020

omerb4 commented Mar 1, 2020

guyharris commented May 12, 2020

omeranson Mar 30, 2022

Choose a reason for hiding this comment

omeranson Mar 30, 2022

Choose a reason for hiding this comment

tr33oph commented Apr 6, 2023

irozzo-1A commented May 24, 2023

acmay commented May 24, 2023 via email

irozzo-1A commented May 25, 2023

fxlb commented May 1, 2019 •

edited