Etw #934
Etw #934
Conversation
| handle->stats_op = pcap_stats_etw; | ||
| handle->read_op = pcap_read_op_etw; | ||
| handle->snapshot = MAXIMUM_SNAPLEN; | ||
| handle->linktype = DLT_USER0; |
There was a problem hiding this comment.
Don't use a DLT_USER value; send an email to tcpdump-workers@lists.tcpdump.org to request that a DLT_ value be assigned for this purpose.
There was a problem hiding this comment.
I'm just sending the email. Thanks for your feedback.
|
This should add |
|
I've added pcap-etw.c into MANIFEST.in but it seems that the build is broken for network reason... |
Neither Travis nor AppVeyor are reliable CI engines; they both sometimes need to have builds re-tried to get them to finish. |
|
As a generic observation, please use a consistent curly braces style, currently the file alternates between Allman and K&R. Since this is a case of a "try-fixup-fixup-fixup" sequence of commits, if anyone comes to the point of merging this request, please do that as a single squashed commit. |
|
Thanks a lot! |
citronneur
force-pushed
the
etw
branch
4 times, most recently
from
b857aa7
to
03a0245
Compare
|
Rebase commit from PR #978, squash into one commit. |
Fix time and perf issue Update: Add extended data for tracelogging capture Fix: comment mispelling Fix: rename pcap_snprintf to snprintf Update: comment
Hello libpcap Team,
I would like to propose you a pull request that allow the libpcap to capture ETW on windows platform.
This pull request is part of a project named Winshark that will be presented at SSTIC, that allow Wireshark to capture and analyze ETW.
Have a nice day,
Sylvain