[optimizer] Recompute dominators if and/or_pullup succeeds #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenarchits
force-pushed
the
2020-pullup-dominator-fix
branch
from
49ac7a3
to
b0e220b
Compare
fxlb
force-pushed
the
2020-pullup-dominator-fix
branch
from
3174a11
to
b25c5d2
Compare
|
Please don't merge, use rebase. |
tenarchits
force-pushed
the
2020-pullup-dominator-fix
branch
from
b25c5d2
to
48bda25
Compare
|
@fxlb - Hopefully I've rebased appropriately today. |
tenarchits
force-pushed
the
2020-pullup-dominator-fix
branch
3 times, most recently
from
d87d994
to
6b7f460
Compare
tenarchits
force-pushed
the
2020-pullup-dominator-fix
branch
from
6b7f460
to
6c85afb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is intended to address #945 . It appears that re-computing the dominator sets as and_pullup and or_pullup change the control flow graph prevents the bug from emerging.