Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport Haiku libnetwork build fixes #1178

Merged
merged 3 commits into from
Apr 24, 2024
Merged

backport Haiku libnetwork build fixes #1178

merged 3 commits into from
Apr 24, 2024

Conversation

infrastation
Copy link
Member

Before:

checking for library containing socket... no
checking for socket in -lsocket... no

> grep HAVE_GETSERVENT config.h
/* #undef HAVE_GETSERVENT */

After:

checking for library containing gethostbyaddr... -lnetwork
checking for library containing socket... none required

> grep HAVE_GETSERVENT config.h
#define HAVE_GETSERVENT 1

See also #1177.

guyharris and others added 3 commits April 24, 2024 17:41
@guyharris @infrastation
configure: check for gethostbyaddr(), not gethostbyname().
758101e 
We use gethostbyaddr() to translate IP addresses in packets to names; we
don't use gethostbyname() to translate names to IP addresses (libpcap
does the latter when compiling filters, so we leave that up to it, and
nothing's left for us to do).

This probably has the same effect as checking for gethostbyname(), but
it makes it a bit clearer why we'd check for it.

(cherry picked from commit b1ccc20)
@korli @infrastation
autoconf: search for gethostbyaddr() in libnetwork
5194aca 
This is needed for building on Haiku.

(cherry picked from commit 13b7faa)
@davidkaroly @infrastation
CMake: search for gethostbyaddr() in libnetwork
a9fef42 
(cherry picked from commit bdece16)
@infrastation infrastation merged commit a9fef42 into the-tcpdump-group:tcpdump-4.99 Apr 24, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@infrastation @guyharris @korli @davidkaroly