[WIP] Translation #1044
Draft
[WIP] Translation #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b2a2ca6.
Merge translation code and files
The backup of the original toc.yml will now begenerated on-the-fly. Only toc.yml needs to updated when the chapter structure updats.
…uage team or creating a new one
…ring-way into translation
|
I've put up a pull request to add @tonyyzy! 🎉 |
|
@tonyyzy Thank you for adding the missing authors and author badges. I would need a bit more context for the shell file created in this PR and the final locations for the translated files. Would you be able to demo that for me over a call? |
malvikasharan
approved these changes
Apr 21, 2020
There was a problem hiding this comment.
Thank you so much @tonyyzy. I am approving this PR with the details as is. We might need to adapt the TOC for the new version soon.
This reverts commit fdbcc15.
|
❌ Deploy Preview for condescending-spence-915096 failed. 🔨 Explore the source changes: 19db0c9 🔍 Inspect the deploy log: https://app.netlify.com/sites/condescending-spence-915096/deploys/62333c3ae492920008de9d24 |
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently on hold till restructure #977 is done
The first portion of translation merge. Contains the first chapter of Chinese translation and the multilingual build infrastructure setup.
List of changes proposed in this PR (pull-request)
What should a reviewer concentrate their feedback on?
multilingual_make.shdoes the procedure make sense?Acknowledging contributors