Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dead link to eScience Center language guides #2995

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

tpronk
Copy link
Contributor

@tpronk tpronk commented Mar 14, 2023

Summary

Fixes a dead link to the eScience Center language guides.

List of changes proposed in this PR (pull-request)

  • Dead link fix

What should a reviewer concentrate their feedback on?

  • Check if the new link points to the right page

Acknowledging contributors

@welcome
Copy link

welcome bot commented Mar 14, 2023

Thank You Banner
💖 Thanks for opening this pull request! 💖 The Turing Way community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.
If you are submitting a new chapter, here are some things that will help get your pull request across the finish line! 🏁

  • Check you have removed all lorem ipsums from the chapter template (if you used it)
  • Check for any abbreviations or latin phrases (such as "e.g." or "i.e.") in your writing. See our style guide for more information on this topic.
  • Make sure you have added your new chapter to the Table of Contents

    We have Continuous Integration tests that check the writing style and will help you track down any slip-ups ♻️ The Netlify bot will also comment with a preview of the book with your additions so you can see how it will look once it's merged! 🎉

    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. If we don't acknowledge this pull request after 7 days, feel free to chat to us about it in our Slack workspace.

@netlify
Copy link

netlify bot commented Mar 14, 2023

Deploy Preview for the-turing-way ready!

Name Link
🔨 Latest commit 5996455
🔍 Latest deploy log https://app.netlify.com/sites/the-turing-way/deploys/64104cc68b7e4100085ed443
😎 Deploy Preview https://deploy-preview-2995--the-turing-way.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@da5nsy da5nsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @tpronk!
All LGTM!

@da5nsy
Copy link
Collaborator

da5nsy commented Mar 14, 2023

@all-contributors please add @tpronk for bugs

@allcontributors
Copy link
Contributor

@da5nsy

I've put up a pull request to add @tpronk! 🎉

@da5nsy
Copy link
Collaborator

da5nsy commented Mar 29, 2023

Feel free to go ahead and hit merge @tpronk! 👍

@tpronk tpronk closed this Mar 30, 2023
@tpronk tpronk reopened this Mar 30, 2023
@tpronk
Copy link
Contributor Author

tpronk commented Mar 30, 2023

Cool! I don't think I've got the rights to hit merge though @da5nsy

@da5nsy
Copy link
Collaborator

da5nsy commented Mar 30, 2023

Oop, sorry, my bad!

@da5nsy da5nsy merged commit 9d69415 into the-turing-way:main Mar 30, 2023
@welcome
Copy link

welcome bot commented Mar 30, 2023

Congratulations Banner
Congrats on merging your first pull request! 🎉 We here at The Turing Way are proud of you! 💖 Thank you so much for your contribution 🎁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants