Pass user to parse and request to render #35

n-peugnet · 2023-02-09T19:02:13Z

Some extensions like flarum-mentions or club-1-cross-references make use of these additional parameters. So we need to pass these to able to render the messages.

See parse and render signatures from the API docs : https://api.docs.flarum.org/php/v1.6.0/flarum/formatter/formatter

Fixes #34

n-peugnet · 2023-02-09T20:49:58Z

You should then bump your flarum/core version to ^1.6.0 in composer.json as the third parameter of parse() is only present since this commit : flarum/flarum-core@f54bd6f

(The request parameter of render() is there since 1.3.0 : flarum/flarum-core@c3d9f43)

I didn't do it in this commit as the changes in composer.json and composer.lock would have added a lot of noise in the diff.

As it seems a lot of extension do not set the parameter when calling Formatter->render(), we fallback to unknown discussion rendering when request is null. We keep logging an error, as this issue should be solved in these extensions. See also <the-turk/flarum-diff#35> for an example of how to fix this issue.

n-peugnet · 2023-02-12T19:30:15Z

Hmm this is strange. I am sure that it worked, but this does not seem to work anymore. I'm investigating.

Some extensions like flarum-mentions or club-1-cross-references make use of these additionnal parameters. So we need to pass these to able to render the messages

n-peugnet · 2023-02-12T21:42:57Z

Okay. I just pushed a new commit to pass the correct actor to parse() for each revision.

n0099 · 2023-03-05T11:01:40Z

LGTM
related: s9e/TextFormatter#214

rafaucau · 2023-04-09T09:35:17Z

@the-turk Could you please merge?

n0099 · 2023-04-09T15:12:00Z

@the-turk Could you please merge?

You can apply changes in this pr without waiting for @the-turk to merge it and bump a new version on packagist by switching the source of package the-turk/flarum-diff from packagist to branch club-1/flarum-diff/fix-parse-and-render-missing-args in composer.json:
https://getcomposer.org/doc/05-repositories.md
https://stackoverflow.com/questions/12954051/use-php-composer-to-clone-git-repo

Pass user to parse and request to render

e2a1058

Some extensions like flarum-mentions or club-1-cross-references make use of these additionnal parameters. So we need to pass these to able to render the messages

n-peugnet force-pushed the fix-parse-and-render-missing-args branch from 5b0bb2a to e2a1058 Compare February 12, 2023 21:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pass user to parse and request to render #35

Pass user to parse and request to render #35

n-peugnet commented Feb 9, 2023 •

edited

n-peugnet commented Feb 9, 2023 •

edited

n-peugnet commented Feb 12, 2023

n-peugnet commented Feb 12, 2023

n0099 commented Mar 5, 2023 •

edited

rafaucau commented Apr 9, 2023

n0099 commented Apr 9, 2023

Pass user to parse and request to render #35

Are you sure you want to change the base?

Pass user to parse and request to render #35

Conversation

n-peugnet commented Feb 9, 2023 • edited

n-peugnet commented Feb 9, 2023 • edited

n-peugnet commented Feb 12, 2023

n-peugnet commented Feb 12, 2023

n0099 commented Mar 5, 2023 • edited

rafaucau commented Apr 9, 2023

n0099 commented Apr 9, 2023

n-peugnet commented Feb 9, 2023 •

edited

n-peugnet commented Feb 9, 2023 •

edited

n0099 commented Mar 5, 2023 •

edited